Maniphest T33722

ugly old toolbar icons - height inconsistent
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	eranroz
	Oct 15 2011, 9:14 AM

Tags

Referenced Files

None

Subscribers

MarkAHershberger

• wikibugs-l-list

Description

Toolbar icons in the old toolbar are defined to be 23X23 (see here:
http://en.wikipedia.org/w/resources-1.18/resources/mediawiki.action/mediawiki.action.edit.js in insertButton)

but the images are 23X22, for example:
http://bits.wikimedia.org/skins-1.18/common/images/button_bold.png
http://bits.wikimedia.org/skins-1.18/common/images/button_link.png

And it is ugly!

Version: 1.18.x
Severity: normal

Details

Reference: bz31722

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:49 PM

• bzimport added a project: MediaWiki-User-Interface.

• bzimport set Reference to bz31722.

• bzimport added a subscriber: Unknown Object (MLST).

eranroz created this task.Oct 15 2011, 9:14 AM

Was indeed always 23x22
http://svn.mediawiki.org/viewvc/mediawiki/branches/REL1_16/phase3/skins/common/edit.js?view=markup

Was changed when merged to the mediawiki.action.edit.js

http://svn.mediawiki.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js?r1=80582&r2=83067

(In reply to comment #1)

Was changed when merged to the mediawiki.action.edit.js

Copy paste mess, I meant r86603

don't think ugly icons should block the tarball

This was fixed in r101990