Uncaught TypeError: Cannot read property 'syntaxOk' of null
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	He7d3r
	Oct 15 2011, 3:43 PM

Description

If I go to the URL above and click in the field named "Conditions:" and then press a key such as CTRL, I get the following error in Google Chrome:

Uncaught TypeError: Cannot read property 'syntaxOk' of null

the error is cause in the line

if ( el.syntaxOk ) {

of the JS which appears inside of a <script type="text/javascript"> tag in a page such as this:
https://pt.wikipedia.org/wiki/Especial:AbuseFilter/history/105/item/1122

I think it can be fixed by first checking if is different of null and only then checking for el.syntaxOk.

Version: unspecified
Severity: normal
URL: https://pt.wikipedia.org/wiki/Especial:AbuseFilter/history/105/item/1122?uselang=en

Details

Reference: bz31729

	Title	Reference	Author	Source Branch	Dest Branch
	Correct descriptions and URLs of custom default project menu items	repos/phabricator/extensions!23	aklapper	T337297	wmf/stable
	Correct descriptions and URLs of custom default project menu items	repos/phabricator/extensions!7	aklapper	aklapper-wmf/stable-patch-05641	wmf/stable

Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:49 PM

• bzimport added projects: AbuseFilter, good first task, JavaScript.

• bzimport set Reference to bz31729.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Oct 15 2011, 3:43 PM

The error also happens on Firefox 7.0.1.

Erro: el is null
Arquivo-fonte: https://pt.wikipedia.org/wiki/Especial:AbuseFilter/history/105/item/1122?uselang=en

Linha: 549

So, looking at where that error happens, and the code around it, I see wgFilterBoxName. Looks like that bit of js (edit.js) was removed in r95572. Maybe all that is needed is an update?

CCing Roan who reviewed the code before to see if he thinks it is ready to be deployed.

(In reply to comment #3)

CCing Roan who reviewed the code before to see if he thinks it is ready to be
deployed.

If you're talking about r95572, that's an enormous revision and shouldn't be deployed by itself.

beau wrote:

It seems the fix has been deployed some time ago.

Uncaught TypeError: Cannot read property 'syntaxOk' of nullClosed, ResolvedPublicActions