Author: ch-va
Description:
After the 1.18 update old patrolling link "Mark as patrolled" disappeared, but in some Namespaces (such as Category, Page, Page talk, User talk etc) there are no now any patrolling instruments, so pages in such namespaces can't be patrolled at all.
Version: 1.18.x
Severity: normal
(In reply to comment #0)
After the 1.18 update old patrolling link "Mark as patrolled" disappeared, but
in some Namespaces (such as Category, Page, Page talk, User talk etc) there
are no now any patrolling instruments, so pages in such namespaces can't be
patrolled at all.
On what wiki?
Do these pages have "!" marks in Special:RecentChanges (or Special:Watchlist) and are highlighted at Special:NewPages?
ch-va wrote:
(In reply to comment #3)
Do these pages have "!" marks in Special:RecentChanges (or Special:Watchlist)
and are highlighted at Special:NewPages?
At Special:NewPages they are highlighted, but in Special:RecentChanges they are not marked with "!" sign (may be bug too?) though I can choose "hide patrolled" and get a list of unpatrolled pages (without "!" mark). Some of them in Special:RecentChanges page have label "[непроверенные изменения]" ("[unpatrolled changes]") but as far as i see this is for pages that were patrolled before, than new changes were made. Pages that were not patrolled at all are only shown in "Recent changes page" but without any "!" signs.
Before 1.18 for pages in such namespaces (e.g. Category, Page, Index, Page talk and so on) there was label "mark this page as patrolled" at the bottotom of the page. Now there is no such label and there is no New Page Patroll buttons (like at Main namespace).
Do any of the new pages have [непроверенная страница] ("unreviewed page")?
Also, what pages *can* new pages be patrolled in?
ch-va wrote:
(In reply to comment #5)
Do any of the new pages have [непроверенная страница] ("unreviewed page")?
No, just [непроверенные изменения]" ("[unpatrolled changes]"). AFAIK, in ru.wikipedia after 1.18 "!" disappeared too, but they somehow fixed it themselves (on ru.wikipedia there are much more users than on ru.wikisource, some of them have good programming skills, on ru.wikisource there are no such users).
Also, what pages *can* new pages be patrolled in?
I'm sorry, English is not my native, so I may be don't undersatnd the question. Pages in such namespaces as Main, Talk:, Spacial, Special talk, File, Template, Help have New Page Patrol buttons, other not.
Pages in Page namespace have his own patrolling system (Extension:Proofread Page), but even if thir staus is set as "Proofread" status, they are shown as unpatrooled in RecentChanges list (may be this is a bug to, before 1.18 such pages also had label "mark this page as patrolled").
ch-va wrote:
(In reply to comment #7)
Can Administrators patrol these pages or no one at all?
In such names Administrators can't patrol these pages because there is no instruments for patrolling in these pages (before 1.18 there were links "Mark this page as patrolled" at the bottom of the pages).
I've made some site config change cleanups.
OK, so http://ru.wikisource.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:ListGroupRights shows that administrators have 'patrol' which should give them [mark as patrolled] links.
ch-va wrote:
(In reply to comment #9)
I've made some site config change cleanups.
OK, so
http://ru.wikisource.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:ListGroupRights
shows that administrators have 'patrol' which should give them [mark as
patrolled] links.
As I see in this page the «old patrol system» (patrol) is striked. May be this means that old patrol system is dusabled or something like this?
I'm andministrator and bureaucrat don't see these links, neither other admins.
Looks like someone edited http://ru.wikisource.org/wiki/MediaWiki:Right-autopatrol to customize the message. Perhaps the links are being hidden with site JavaScript or CSS?
I just looked at Special:NewPages and clicked http://ru.wikisource.org/w/index.php?title=%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Gzen92&redirect=no&rcid=637143 . I see a [mark as patrolled] link there.
ch-va wrote:
(In reply to comment #12)
I just looked at Special:NewPages and clicked
http://ru.wikisource.org/w/index.php?title=%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Gzen92&redirect=no&rcid=637143
. I see a [mark as patrolled] link there.
Well I can see it too. I experiment and found out that http://ru.wikisource.org/w/index.php?title=%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Gzen92&redirect=no
shows no such link
So the reason is "&rcid=637143" in URL How did you get such rcid and how to generate it for any page (not only in User talk name but in other namespaces too).
See for example http://ru.wikisource.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:RecentChanges&limit=500&hideReviewed=1
these pages are unpatrolled then open they don't have [mark as patrolled link] and some of them don't have new patrol system.
ch-va wrote:
(In reply to comment #12)
I just looked at Special:NewPages and clicked
http://ru.wikisource.org/w/index.php?title=%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Gzen92&redirect=no&rcid=637143
. I see a [mark as patrolled] link there.
Well I can see it too. I experiment and found out that http://ru.wikisource.org/w/index.php?title=%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Gzen92&redirect=no
shows no such link
So the reason is "&rcid=637143" in URL How did you get such rcid and how to generate it for any page (not only in User talk name but in other namespaces too).
See for example http://ru.wikisource.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:RecentChanges&limit=500&hideReviewed=1
these pages are unpatrolled then open they don't have [mark as patrolled link] and some of them don't have new patrol system.
ch-va wrote:
(In reply to comment #11)
Looks like someone edited
http://ru.wikisource.org/wiki/MediaWiki:Right-autopatrol to customize the
message. Perhaps the links are being hidden with site JavaScript or CSS?
before 1.18 there were no such problem so I think the reason is 1.18 MediaWiki update.
All the links on Special:NewPages to unpatrolled pages have and rcid=x parameter in them. [mark as patrolled] will not show without it, yes.
ch-va wrote:
(In reply to comment #16)
All the links on Special:NewPages to unpatrolled pages have and rcid=x
parameter in them. [mark as patrolled] will not show without it, yes.
Well, before 1.18 I could open new pages from Special:RecentChanges and they had [mark as patrolled link] too. Anyway I will use Special:NewPages for now.
But the main question is the same: is it possible to integrate new patrol system in all namespaces? Why do we have to patrolling methods for the same time and one of them is acccessible only from Special:NewPages. The new patrol system is more easy-to-use
ch-va wrote:
(In reply to comment #16)
All the links on Special:NewPages to unpatrolled pages have and rcid=x
parameter in them. [mark as patrolled] will not show without it, yes.
Hmm... Special:NewPages is not always good for ptrolling. Pages which was recently modified didn't shown there. It's better then nothing though.
(In reply to comment #17)
(In reply to comment #16)
All the links on Special:NewPages to unpatrolled pages have and rcid=x
parameter in them. [mark as patrolled] will not show without it, yes.Well, before 1.18 I could open new pages from Special:RecentChanges and they
had [mark as patrolled link] too. Anyway I will use Special:NewPages for now.But the main question is the same: is it possible to integrate new patrol
system in all namespaces? Why do we have to patrolling methods for the same
time and one of them is acccessible only from Special:NewPages. The new patrol
system is more easy-to-use
So right now we have "reviewing" (FlaggedRevs) and "patrolling" (RC patrol).
FlaggedRevs is intended to be for actual content pages (though it could be enabled for any normal non-Talk namespace...it's not recommended). New page patrol is intended as a simple, light-weight, tool for people to check over pages with.
Also see bug 15936 for showing the patrol link even with no rcid=x parameter.
ch-va wrote:
(In reply to comment #19)
So right now we have "reviewing" (FlaggedRevs) and "patrolling" (RC patrol).
FlaggedRevs is intended to be for actual content pages (though it could be
enabled for any normal non-Talk namespace...it's not recommended). New page
patrol is intended as a simple, light-weight, tool for people to check over
pages with.
OK. Is it possible to enable it from Special:RecentChanges again?
I have enabled recentchanges patrolling on ruwikisource ( wgUseRCPatrol = true ):
+++ InitialiseSettings.php (working copy)
@@ -5758,6 +5758,7 @@
'ptwiki' => true, // https://bugzilla.wikimedia.org/show_bug.cgi?id=4500 'ptwikibooks' => true, // https://bugzilla.wikimedia.org/show_bug.cgi?id=30136 'rowiki' => true, // https://bugzilla.wikimedia.org/show_bug.cgi?id=28192
+ 'ruwikisource' => true, //https://bugzilla.wikimedia.org/31745
'ruwikiversity' => true, 'siwiki' => true, 'srwiki' => true, // req by dungodung in #wikimedia-tech, 2008-02-25
local revision 2630
Still need to investigate the different behaviors between namespaces.
ch-va wrote:
(In reply to comment #22)
I have enabled recentchanges patrolling on ruwikisource ( wgUseRCPatrol = true
):
Now I can see red "!" in RecentChanges list but still NO "mark as patrolled" links.
I thought only new page patrol was desired.
A fix for that would be to make links to new pages in ChangesList have rcid if unpatrolled.
I can't see the ! marks, but they are in the source:
'<abbr class="unpatrolled" title="This edit has not yet been patrolled">!</abbr>'
Looks like it's hidden by '.unpatrolled {visibility:hidden}' in MediaWiki:Common.css.
(In reply to comment #24)
I thought only new page patrol was desired.
A fix for that would be to make links to new pages in ChangesList have rcid if
unpatrolled.
Added in r103614.
Antoine, can you revert the config change and resolve invalid (since it is site CSS that is hiding the links)?
wgUseRCPatrol is now disabled on ruwikisource ( local revision is 2650)
Marking bug as INVALID. Local stylesheet need to be updated to show the 'mark as patrolled' link.
ch-va wrote:
(In reply to comment #29)
wgUseRCPatrol is now disabled on ruwikisource ( local revision is 2650)
Marking bug as INVALID. Local stylesheet need to be updated to show the 'mark
as patrolled' link.
What change should be done?
I think I got confused in all the clutter. The CSS change would only get "!" marks back, not make new page links on RC have rcid=x. I'd need to merge the above patch for that.
(In reply to comment #31)
I think I got confused in all the clutter. The CSS change would only get "!"
marks back, not make new page links on RC have rcid=x. I'd need to merge the
above patch for that.
Done. The CSS was fixed too.