Page MenuHomePhabricator

The check mark image and the cross mark image no longer appear
Closed, ResolvedPublic

Description

Author: dy_yol

Description:
The check mark image and the cross mark image no longer appear when "Check syntax", "Test" and "Test filter" buttons are hit.

Image of check mark: http://commons.wikimedia.org/wiki/File:Yes_check.svg
Image of the cross mark http://en.wikipedia.org/wiki/File:X_mark.svg


Version: unspecified
Severity: normal

Details

Reference
bz31870

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:48 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz31870.

I'm removing needs-regression-test as it's not super easy to make a test for that right now.

Main problem was r81905, which consolidated separate 'border-repeat' and 'border-position' specifications into a single 'border' rule. This unfortunately creates an implied 'background-image: none', which overrides the background-image: url(yes_check.png) etc.

Undoing that seems to help.

Additionally on trunk, the files didn't get moved along with the CSS so can't be found.

Fixed on trunk in r101756. Needs a slightly different patch for 1.18 (pre resourceloaderification of the ext)

Fixed on REL1_18 in r101758. Marking for merge to 1.18wmf1 for upcoming deployment.