Page MenuHomePhabricator

Addition of PPFrame::getTitle
Closed, ResolvedPublic

Description

Author: van.de.bugger

Description:
Let us make frame title available through method getTitle. It allows parser functions to access title of current frame. It makes possible magic words or parser functions which know the name of current frame, like {{SRCNAME}} (discussed in 24284). In turn, {{SRCNAME}} makes possible "template-scope" variables, e. g. {{ #vardefine: {{SRCNAME}}:i }}, {{ #var: {{SRCNAME}}:i }}. It also makes possible extensions which does the same even more gracefully: {{ #localdefine: i }}, {{ #local: i }}. (localdefine, local are parser function which set/get "template-scope" variables; I wrote "template-scope" in parentheses because these variables are available outside by using "full" name: {{ #var: Templatename:i }}.)


Version: unspecified
Severity: enhancement

Details

Reference
bz31995

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:57 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz31995.
bzimport added a subscriber: Unknown Object (MLST).

van.de.bugger wrote:

Trivial getTitle implementation.

Attached:

sumanah wrote:

Adding the "need-review" and "patch" keywords, for patches that need review by developers. Van de Bugger, thank you for your patch.

Reviewed, and applied in r102571

Also did Preprocessor_HipHop as it exists in trunk (and 1.18?)

Technically wasn't needed, because $title is var (so public), but certainly the better way to do it than direct member variable access!

Thanks

van.de.bugger wrote:

Verified on r102853.

Great, it once took me a while to get the idea that there was a public $mTitle. For additions like this I would really appreciate to see the '@since' in the function documentation. Would make it a lot easier to keep backwards compatibility in extensions.