Page MenuHomePhabricator

Improve messages output by the database updaters
Closed, DeclinedPublic

Description

Per Nikerabbit on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101079#c25074

"So if the table doesn't exist, the only output is "...foo doesn't exist.". That's quite weird and ambiguous I think."

We should update the updater functions so full lines (sentences, even) are output, rather than full in some cases, half in others


Version: 1.20.x
Severity: trivial

Details

Reference
bz32020

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:58 PM
bzimport set Reference to bz32020.
bzimport added a subscriber: Unknown Object (MLST).

david_baumgarten wrote:

improved updater output messages

Attached:

david_baumgarten wrote:

Hello,

i've changed the updater functions and now the Output looks like this:
"Dropping table foo... foo doesn't exist, skipping drop table"
i've also changed the dropfield,addTable,etc functions that the output full lines

sumanah wrote:

David, thank you for the patch. I am asking developers to review it. Chad Horohoe said that he hasn't had time to write up a reply to you, but that we can't take your patch as it is right now, since doing it the way the patch proposes would undo another bugfix. I'm going to get someone to give you an actually *informative* review as soon as possible. Thanks again.

change reverted by r103892 because of bug 32508 "too many update messages even though nothing happens"

priyrahulmishra wrote:

improved updater output messages

Attached:

Hi Rahul! Thanks for your patch!
Patches must go to Gerrit instead of Bugzilla though.

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/

What's the status of this bug?

See the comments and information above. What's specifically unclear?
There's a patch and somebody needs to put that patch into Gerrit.

What's the status of this bug?

See the comments and information above. What's specifically unclear?
There's a patch and somebody needs to put that patch into Gerrit.

Looking at current master, some messages are getting output and they don't seem to be too verbose. I have a suspicion that the code has been updated without referencing this bug.

hashar claimed this task.

A previous attempt in 2011 has been found to be to verbose ( T34508 ). The whole updater / installer output needs a large overhaul.