Page MenuHomePhabricator

update.php has useless/obscure error message
Closed, ResolvedPublic

Description

I updated my wiki to r101337 just now and tried to run the following command and was presented with the following output:


$ php maintenance/update.php
Do not run update.php on this wiki. If you're seeing this you should
probably ask for some help in performing your schema updates.

If you know what you are doing, you can continue with --iknowwhatimdoing

This error message is frightening and overly vague. It was introduced in r92109. It should include one or more of the following: a link to a manual or help page on mediawiki.org explaining what the actual issue is here and what needs to be done to resolve it; a reference to the global configuration variable ($wgMiserMode); a link to [[mw:Manual:$wgMiserMode]].

It looks like the help output was modified, but I think most people wouldn't think to look there (the only reason I knew that the help output was modified was by someone pointing out r92109 to me).


Version: unspecified
Severity: normal

Details

Reference
bz32072

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:02 AM
bzimport set Reference to bz32072.
bzimport added a subscriber: Unknown Object (MLST).

I assume this is a XXXwmf branch?

(In reply to comment #1)

I assume this is a XXXwmf branch?

No, I did it in trunk so we wouldn't lose it every time we rebranch a deployment branch.

How about instead we set a configuration switch so it only has to happen on the cluster, and it works for everybody else?

Well I was reusing $wgMiserMode for that purpose, but apparently real people use miser mode too.

renamed by Aaron in r101370 to --force

Stopped abusing $wgMiserMode in r101867.