Page MenuHomePhabricator

HistoryAction.php gives MySQL-warning when no matching revisions are found
Closed, ResolvedPublic

Description

patch against trunk

For example: http://<some1.19.wiki>/w/index.php?title=Main_Page&action=history&tagfilter=abcd123

HistoryPager::doBatchLookups() doesn't check for an empty result set before calling ResultWrapper::seek(0).


Version: 1.20.x
Severity: normal

Attached:

Details

Reference
bz32134

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:06 AM
bzimport set Reference to bz32134.

john wrote:

Thank for very much for the patch and bug report. I've fixed this in r101629 using an alternate method. So instead of only checking if there are results before using seek, we can return from the function immediately as nothing will be accomplished with no results anyway.

Hope to see some more patches and reports from you soon :)