Page MenuHomePhabricator

Change "Importance" label to "Priority and Severity"
Closed, DeclinedPublic

Description

Clicking on "Importance" in a standard bug view leads to https://bugzilla.wikimedia.org/page.cgi?id=fields.html#importance. This page doesn't describe importance levels at all and has no "importance" anchor. This should be fixed.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56372

Details

Reference
bz32164

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:58 PM
bzimport set Reference to bz32164.
bzimport added a subscriber: Unknown Object (MLST).

https://bugzilla.mozilla.org/show_bug.cgi?id=453023 says this is "fixed" in 3.2 so obviously something we've screwed up.

Should just be a matter of fixing/updating fields.html.

-easy, Easy is for things that people with commit access can easily fix.

Based on chad, this actually sounds like its needs ops to fix it.

(In reply to comment #3)

-easy, Easy is for things that people with commit access can easily fix.

Based on chad, this actually sounds like its needs ops to fix it.

Not that I really care about the keywords... I think the Bugzilla config is in SVN, so this is pretty much like anything else that needs to be fixed (commit by devs, review by devs, deploy by sysadmins). If the Bugzilla config isn't in SVN, that'd be a separate bug.

Our BZ customizations are indeed in SVN, see /trunk/tools/bugzilla/

Should just be a matter of putting the current fields.html in there and making the customizations we need.

There are two entries at https://bugzilla.wikimedia.org/page.cgi?id=fields.html, one for "severity" and one for "priority" that would appear to be applicable and would make more sense than the current Importance followed by two otherwise unexplained drop downs. It looks like the first menu actually corresponds to "priority" and is supposed to be changed by the assigned dev, and that the second drop down corresponds to "severity". So it's mainly the labels that need to be changed, not the documentation, though it could be clarified.

I've changed the description of this bug as the link from "importance" isn't really the problem, it's that it shouldn't say "importance" at all.

Additionally, if these are to be used the way the documentation suggests, the priority should default to "unprioritized" not "normal" since the bug should have a priority unless it has been assigned.

(In reply to comment #7)

Additionally, if these are to be used the way the documentation suggests, the
priority should default to "unprioritized" not "normal" since the bug should
have a priority unless it has been assigned.

Please see https://www.mediawiki.org/wiki/Bug_management/Bugzilla_usage for an explanation of how we're using the fields. If you disagree with the use there, please let me know.

No disagreement. Just quoting the current sections at https://bugzilla.wikimedia.org/page.cgi?id=fields.html. The mediawiki.org documentation is better or at least more what we're doing, so we should make it clear.

So we need to:

  1. Change the field title "importance" to two field titles, "priority" and "severity"
  2. Change the links to the relevant sections and make #Priority and #Severity valid anchors (e.g. https://bugzilla.wikimedia.org/page.cgi?id=fields.html#severity)
  3. Remove the text at Priority and Severity and link to to mediawiki.org or replace the current text with mediawiki.org text to make the usage of these fields standard

We probably ought to reconcile all the documentation at https://www.mediawiki.org/wiki/Bugzilla/Fields with https://bugzilla.wikimedia.org/page.cgi?id=fields.html while we're about it. One should simply link to the other so that we only have to make changes in one place. mw.org seems like the better place to keep the documentation as it's easier to tweak there.

As long as I can remember there is no field "Importance".

We already have a Priority and Severity drop down menu. Those fields are shown next to eachother in the form at the label "Importance".

(In reply to comment #11)

As long as I can remember there is no field "Importance".

We already have a Priority and Severity drop down menu. Those fields are shown
next to eachother in the form at the label "Importance".

In comment 9, item 1, I was referring to the label/lack of labels. Calling them Priority and Severity and labeling them "importance" is at best confusing and is the point of this bug. The point is that there is nothing to tell anyone that they are actually known as priority and severity and there is no link to the actual usage only to a non-existent anchor on the bugzilla fields page.

Thehelpfulonewiki wrote:

Resetting to default per bug 37789

template/en/default/bug/edit.html.tmpl :
<b><a href="page.cgi?id=fields.html#importance"><u>I</u>mportance</a></b></label>:

extensions/Voting/template/en/default/pages/voting.html.tmpl :
<li>Click on the "(vote)" link that appears on the right of the "Importance"

(In reply to comment #14)

Upstream ticket about current inconsistency is
https://bugzilla.mozilla.org/show_bug.cgi?id=453023

and it was fixed in 2008 in 3.2. I'm not sure why our BZ's Bug Fields page doesn't have the better text and links from the fix https://bugzilla.mozilla.org/attachment.cgi?id=338722&action=diff

I improved the wiki documentation to reflect the current layout, https://www.mediawiki.org/wiki/Bugzilla/Fields#Importance (the old page referenced here Bug_management/Bugzilla_usage redirects).

(In reply to comment #6)

I've changed the description of this bug as the link from "importance" isn't
really the problem, it's that it shouldn't say "importance" at all.

Perhaps, or add some fairly obvious on-page indicator that Importance is comprised of priority and severity.

S: Thanks for your updating!

Bug 42524 covers that I'd like https://bugzilla.wikimedia.org/page.cgi?id=fields.html to simply become a redirect to the wikipage (easier to update).

Thanks, but it could still be improved. Compare hovering over the Importance field with the URL field. The latter has a nice help cursor and a tooltip explaining it.

So change

<a href="page.cgi?id=fields.html#target_milestone">

Target&nbsp;Milestone</a>

to add
class="field_help_link" title="Importance is a combination of priority and severity".

Several other fields are missing the help cursor and title tooltip.

(In reply to comment #20)

Thanks, but it could still be improved. Compare hovering over the Importance
field with the URL field. The latter has a nice help cursor and a tooltip
explaining it.

Sounds good. Might even be something to fix upstream.
However the original request here (Change Importance label) is a WONTFIX to me.

Closing per comment 21; I opened 56372 for adding the help cursor and title tooltip as suggested in comment 20.