Page MenuHomePhabricator
Create Task
Maniphest T34183

Remove user-agent-sniffed client-* classes from mediawiki.page.startup
Closed, ResolvedPublic
Actions

Description

Browser sniffing is unreliable, dangerous, and generally nasty and should almost never be used.

mediawiki.page.startup.js adds classes to the <html> document element for the client name, version, and a couple other bits -- their presence encourages usage of sniffing to enable/disable features.

Version: 1.20.x
Severity: minor

Details

Reference
bz32183

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:59 PM
• bzimport added projects: MW-1.18.0-release, MediaWiki-JavaScript.
• bzimport set Reference to bz32183.
• brion created this task.Nov 3 2011, 6:57 PM
DanielFriesen added a comment.Nov 3 2011, 7:01 PM

+1

The idea of versions in a css class is ABSOLUTELY horrifying to top off the bad parts about browser sniffing in general.

• brion added a comment.Nov 3 2011, 7:12 PM

Only ones that seem to be in use in extensions are client-js and client-nojs, which are reasonably sensible.

• brion added a comment.Nov 3 2011, 7:19 PM

Done on trunk in r101860.

hashar added a comment.Nov 8 2011, 10:42 AM

marking bug for 1.18 tarball release since r101860 is tagged as such.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL