Page MenuHomePhabricator
Create Task
Maniphest T34201

Redirection from http to https on gerrit.wikimedia broken for some URLs
Closed, ResolvedPublic
Actions

Description

If you access gerrit.wikimedia.org via http you are redirected to https. But URLs with a semicolon are broken after the redirect:

https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=tree;f=files/apache/sites;h=14baed1d9e959206c8fa15a6ff8e79bac2d04ab0;hb=HEAD
works,
but
http://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=tree;f=files/apache/sites;h=14baed1d9e959206c8fa15a6ff8e79bac2d04ab0;hb=HEAD
redirects to
https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git%3ba=tree%3bf=files/apache/sites%3bh=14baed1d9e959206c8fa15a6ff8e79bac2d04ab0%3bhb=HEAD
which gives a 404.

Version: unspecified
Severity: normal
URL: http://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=tree;f=files/apache/sites;h=14baed1d9e959206c8fa15a6ff8e79bac2d04ab0;hb=HEAD

Details

Reference
bz32201
TitleReferenceAuthorSource BranchDest Branch
BaseTriggerView: Populate empty optional fieldstoolforge-repos/ifttt!20bd808work/bd808/T342014main
Get upstream tests working againtoolforge-repos/ifttt!19bd808work/bd808/T342014main
Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:01 AM
• bzimport added a project: HTTPS.
• bzimport set Reference to bz32201.
• bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.Nov 4 2011, 11:17 AM
MarkAHershberger added a comment.Nov 9 2011, 5:05 PM

how often are people removing the "s" from a url they paste somewhere?

Schnark added a comment.Nov 10 2011, 10:21 AM

Just disabling the redirect from http to https at all is probably an acceptable solution. But if the redirect is there, it should work in every case, whether it is used or not.

RyanLane added a comment.Dec 4 2011, 7:13 AM

Fixed in Ie44412e1 (change 1264).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL