neilk wrote:

Good point, we don't have a way to do that now. We should have a way to delete the file on any page, up to the final upload.

The "available" solution is to close the window but yes, this is suboptimal.

drecodeam wrote:

added navigation support to navigate through various steps

Bind click handlers to step titles, to navigate to any step from any step. Click handler in turn invokes the moveToStep('<step name>') with the respective step.

attachment 32247.diff ignored as obsolete

drecodeam wrote:

added .patch file for the previous .diff file

added patch file for the 10256. No changes.

Attached:

sumanah wrote:

Thanks for the patch, drecodeam. I've added some keywords so people know that your patch awaits review, as you can read about in https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes , and I've given you permissions to add those keywords in the future yourself. :-)

sumanah wrote:

Also, drecodeam, you can request a Git/Gerrit account

https://www.mediawiki.org/wiki/Project:Labsconsole_accounts

and submit your patch as a merge request to get it reviewed faster:

https://www.mediawiki.org/wiki/Git/Workflow

Thanks!

drecodeam wrote:

The patch i submitted earlier has some issues with it, as the navigation works but the step divs are not ready right now for navigation. This patch needs more work, and hence is not suitable right now.

• Bug 30687 has been marked as a duplicate of this bug. ***

• Bug 36583 has been marked as a duplicate of this bug. ***

drecodeam, I'm not sure if you're still working on this, but I'm starting to think that it might be better to just add in remove controls on every page until "thanks", serving exactly the same purpose with exactly none of the complications of reverse-navigation. I really can't see a need for moving back to the upload step, since moving *forward* from it would necessarily involve re-uploading the files, which is not a good result. Also, trying to navigate backwards from "thanks" might be complicated, since by that point the files have been fully uploaded and any backwards navigation would involve deleting them from the server and then re-uploading them.

Does anyone have any thoughts on this? Maybe I'm blowing these complications out of proportion?

I have whipped up a quick patch that adds in "remove" functionality at the details step, which is really the only other place that makes sense (excluding the "upload" step which is obvious). It works really well, it's a very minor change, and I'd appreciate review.

Here it is: https://gerrit.wikimedia.org/r/9549

• Bug 34191 has been marked as a duplicate of this bug. ***

[Offtopic] Mark: Can somebody tell me where the keyword "patch-in-gerrit" was discussed (archives URL?) before it was introduced?

About ten minutes ago in MediaWiki-General :)

I had marked a bunch of bugs as patch-need-review, but the description (something like "patch attached, needs review") didn't match what I meant. So Chad added it for me.

Change 9549 had a related patch set uploaded by MarkTraceur:
(bug 32247) Add "remove file" in the details step

https://gerrit.wikimedia.org/r/9549

(In reply to Gerrit Notification Bot from comment #15)

Change 9549 had a related patch set uploaded by MarkTraceur:
https://gerrit.wikimedia.org/r/9549

Patch has been awaiting review for nine months...

https://gerrit.wikimedia.org/r/9549

Patch has been awaiting review for eleven months...

Open for too long, [ Please rebase your change and upload a new patchset.]