Page MenuHomePhabricator

On iOS 5 and earlier, UploadWizard should indicate it doesn't work
Closed, ResolvedPublic

Description

Author: neilk

Description:
On platforms like the iPad, clicking the "add an upload" button does nothing.


Version: unspecified
Severity: minor

Details

Reference
bz32328

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:59 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz32328.
bzimport added a subscriber: Unknown Object (MLST).

neilk wrote:

Actually, there is no way to use a standard file upload control on iOS, period, without installing some 3rd-party software.

UploadWizard does have a problem here, in that it's not obvious it won't work. Normally, on iOS, file upload fields are greyed out.

It may be possible to detect that the <input type="file"> is disabled, in which case we can "gracefully enhance" if Apple gets their act together in iOS 6. :)

Confirmed that the 'disabled' attribute gets set automatically on an <input type="file"> in Safari on iOS 4.3 and 5.0 (tested in simulator).

You can test in isolation by creating an input element dynamically:

if ($('<input type="file">').attr('disabled')) {

		$('#info2').text('file upload is disabled');

} else {

		$('#info2').text('enabled!');

}

Marking as easy, it should be possible to fix this by adding in a simple, proper i18n message to let the user know that the feature isn't supported, and displaying it conditionally on page load. See Brion's comment for some help on how to detect whether the feature is missing.

Note that file uploads are available on iOS 6, and so UploadWizard *should* work there...

Testing on the current beta, things partially work -- after selecting an image I end up with a thumbnail and all -- then I get "Unknown error: unknown-warning" during the upload stage.

Selecting a second image similarly partially works/partially fails, then pops up a dialog warning that "You are already uploading the file "image.jpg"." (apparently every file gets named as image.jpg during uploading...)

Split iOS 6 issue out to bug 39256; adjusting summary to clarify this should apply to iOS 5 and earlier.