Page MenuHomePhabricator

Add upload by URL domain limitation
Closed, ResolvedPublic

Description

https://bugzilla.wikimedia.org/show_bug.cgi?id=14919#c5

The link above requests upload by url for internal WMF usage.

As part of this, it'd make sense to have a limitation in place, so we can allow grabbing from specified url.

That way it gives a sane error message that you can't get it from elrandomsite.com, rather than it timed out getting it from said site (as in the WMF setup, it won't be able to do the request)


Version: unspecified
Severity: enhancement

Details

Reference
bz32341

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:59 PM
bzimport set Reference to bz32341.

svenmanguard wrote:

My god Pandora, what have you done, opening that box?!

If there are any existing or future bug requests seeking to extend this feature to allow uploading from non-WMF sites, please email about me immediately. If improperly implemented, it would (not could, absolutely would) be massively disruptive.

svenmanguard wrote:

(In reply to comment #2)

My god Pandora, what have you done, opening that box?!

If there are any existing or future bug requests seeking to extend this feature
to allow uploading from non-WMF sites, please email about me immediately. If
improperly implemented, it would (not could, absolutely would) be massively
disruptive.

email me about it*

No, there isn't, AFAIK.

This is a software restriction mainly to allow transwiki to commons

There is no way to be able to upload from off site urls directly, so shouldn't be too much of an issue

To also put you at ease, the current setup of the apache webservers means they can't pull content from outside the wikimedia cluster :)

(In reply to comment #1)

Done! r109562

Out again in r109741. It will be coming back post branch!!

svenmanguard wrote:

Implementation question:

Once this goes up, what sort of interface will be built to facilitate the moves, and who will have the ability to initiate the moves?

CommonsHelper, the current transfer bot, functions only occasionally and rarely is the output ideal. ForTheCommonGood, developed by This, that and the other, works much better than CommonsHelper, and with better results. CH is on the toolserver, I believe, while FTCG is not.

I see three implementation options: The development of an upload wizard built into Commons that allows transfers from other projects, the recoding of one or more of those tools to integrate URL uploading, or a combination of both of these things.

While I don't know if coding the interfaces is your job or not, I'd like to hear from you as to which of these will be possible and which of these will be secure enough to be an acceptable option? I'd like to know this before the 1.20wmf deployment, so that I can try and rally a group of people to get the interface working before it goes live. FTCG, simply by virtue of functioning better, has saved the file workers untold hours in post-transfer cleanup; it is important that we make sure that the new transfer interface(s) are as good as possible, as early as possible.

(In reply to comment #7)
Dear Mr. S. Manguard,

and who will have the ability to initiate the moves

  • Ever heard of the upload_by_url right? - [[Special:ListGroupRights]]

While I don't know if coding the interfaces is your job or not

  • No it isn't. There is a very basic interface in trunk/phase3/includes/specials/SpecialUpload.php but you can't expect the MediaWiki devs creating a transfer-tool

I'd like to hear from you as to which of these will be possible

Look at the source code. (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/109562) If you do not understand that, I am sure you won't be able to code an interface.
You could e.g. use the API format JSON/JSONP together with JavaScript = WebApp, which would be the most reasonable approach because it would allow almost all people to use it. The best place to host it would be Commons.

My god Pandora, what have you done, opening that box?!

... no comment ...

Sincerely Rainer Rillke

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:29 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM