Page MenuHomePhabricator

Conflict between Template:Titel and MediaWiki:Common.js on als.wikipedia
Closed, ResolvedPublic

Description

Author: clemens.kienzle

Description:
The Alemannic Wikipedia (als.wikipedia) relies on a template (http://als.wikipedia.org/wiki/Vorlage:Titel) to display article titles in Alemannic, since all articles are created under German titles because of the lack of a standardized Alemannic orthography. This template has worked fine for years.

However, after MediaWiki:Common.js was recently updated following Bug 29595, this template stopped working (instead, every article where it was used displayed "undefined" as the title). Apparently, there is some sort of conflict between Vorlage:Titel and the updated Common.js. We thus had to revert Common.js back to the old version.

It is important to update Common.js because of various problems that the outdated version is causing, but it is even more important to have the Template:Title working properly. Is there a way to re-write the template to make it compatible with the updated Common.js version?


Version: unspecified
Severity: major

Details

Reference
bz32366

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:01 AM
bzimport set Reference to bz32366.

So let's get this clear....

1: Any changes to MediaWiki:Common.js are the responsibility of the local community. So that would be the als community in this case
2: You had trouble with your scripts (community responsibility) that broke some functionality for all users.
3: You came to bug 29595 asking for help (asking people who had NO responsibility since this is not a mediawiki problem, but a local community problem).
4: Krinkle was kind enough to help you fix the scripts.
5: Someone undid all Krinkle's work, without properly explaining what still wasn't fixed, or how certain things should be behaving..
6: You still have issues and now come asking for help again in a new ticket ?

Now what part in that would motivate a developer to help you again ???

clemens.kienzle wrote:

The reason why the changes to MediaWiki:Common.js were undone are explained in this bug, and were also explained in the previous bug by myself and Holder. This bug is preciously to resolve the issue which is preventing the local community from implementing Krinkle's changes to MediaWiki:Common.js. So I'm not sure what you're so upset about.

As far as I'm aware, no one on Wikimedia, be it an editor on a local project or a developer, has a "responsibility" to do anything around here. You're making it sound as if I'm saying "fix our damn problems!", when I'm nicely asking if there is anything a developer is able to do.

I'll take a quick peek at this and see if we can track it down...

It looks like the template http://als.wikipedia.org/w/index.php?title=Vorlage:Titel&action=edit creates a <div id="properTitle"> containing the target title (via a couple alternate methods), which some JS elsewhere is supposed to move over into the title area.

As long as the template's producing the right output, *probably* only the site JavaScript parts need tweaking. I'll see if I can track that down...

Offhand it seems to be working... tested in Firefox 7.0.1 / Ubuntu 11.10.

At https://als.wikipedia.org/wiki/Altenburg-Rheinau the page contains "{{Titel|Oppidum Alteburg-Rhiinau}}"; I see the matching "Oppidum Alteburg-Rhiinau" in the <h1> and the <title> on the page.

If I turn off JavaScript, the page shows the original title "Altenburg-Rheinau" in both places.

What exactly remains as a conflict?

What's wrong with the new Common.js?

If something was broken under the corrected-for-other-unspecified-problems version, what was it exactly? What behavior did you see?

Resolving as duplicate of bug 29595 -- this seems to just be an extension of the fix/rollback cycle started there. Will continue notes over there.

  • This bug has been marked as a duplicate of bug 29595 ***