Page MenuHomePhabricator
Create Task
Maniphest T34469

file upload error messages don't work sanely
Closed, ResolvedPublic
Actions

Description

After specifying the name of a deleted file ("jar2.jpg") on my local install I saw:

There was a file by this name, "File:Jar.jpg", but it was deleted and you
can not reupload the file. If your file is different, try renaming it.

So I gave it "jar.jpg" (the file that had been moved to "jar2.jpg" and then deleted) and I saw this text:

A file with this name exists already.There was a file by this name,
"File:Jar.jpg", but it was deleted and you can not reupload the file. If
your file is different, try renaming it.

That is, "A File with this name exists already." was just added to the beginning of the previous message w/o erasing it.

Version: unspecified
Severity: normal

Details

Reference
bz32469

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:58 PM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz32469.
• bzimport added a subscriber: Unknown Object (MLST).
MarkAHershberger created this task.Nov 17 2011, 10:43 PM
JeroenDeDauw added a comment.Nov 17 2011, 11:06 PM

I tried reproducing this and am getting an alert with "please wait, still checking the title for uniqueness..." instead of any error in the UI, after which nothing happens :/

MarkAHershberger added a comment.Nov 18 2011, 5:44 PM

Actual sequence of events before comment 0:

  1. Uploaded jar.jpg to local wiki with UW.
  2. Moved jar.jpg to jar2.jpg and left a redirect.
  3. Deleted jar2.jpg.

Let me know if that does not let you reproduce this.

JeroenDeDauw added a comment.Nov 18 2011, 6:23 PM

I tried again, those 3 steps, then uploading jar.jpg. And again I'm getting "please wait, still checking the title for uniqueness...".

Looks like we got 2 competing bugs here, fighting for the same turf :)

MarkTraceur added a comment.May 14 2012, 4:58 PM

Mark and Jeroen, can I ask you (though it was a long time ago) what browser(s) you used to test this? I have a sneaking suspicion that IE does something to break how UW does validation.

MarkTraceur added a comment.May 14 2012, 6:48 PM

Jeroen, I think this patch might fix your problem, anyway: https://gerrit.wikimedia.org/r/7608

If not, let me know, because I need to figure out what's causing the issue.

MarkAHershberger added a comment.May 14 2012, 8:10 PM

ping me in another day and I'll look at this. I don't have time right now.

MarkTraceur added a comment.Aug 14 2012, 4:20 PM

Mark, I have totally dropped the ball on this one. Can you take a glance at this sometime soon?

(also, updating keyword to be more better)

MarkTraceur added a comment.Aug 22 2012, 6:49 PM

FWIW, I managed to perform the steps in the original report without issue, so I think we may have gotten a free fix somewhere.

kaldari added a comment.Aug 29 2012, 12:16 AM

Fixed in https://gerrit.wikimedia.org/r/#/c/21211/ and some previous change (don't recall the other one).

• Gilles added a project: Multimedia.Dec 4 2014, 10:23 AM
• Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.
• Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL