Page MenuHomePhabricator

[QuestyCaptcha] Help page is broken
Closed, ResolvedPublic

Description

On the talk page recently an issue was posted [1] that apparently did not make it to bugzilla up till now

When trying to open the help page, the following messages appear:
<pre>
Notice: Undefined property: QuestyCaptcha::$storage in /.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68

Fatal error: Call to a member function cookiesNeeded() on a non-object in /.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68
</pre>

This behaviour may be experienced on MW 1.16, MW 1.17 and MW 1.18 (probably alpha)

Also user Geraschenko posted a patch for it:

<pre>

  • QuestyCaptcha.class.php (revision 103604)

+++ QuestyCaptcha.class.php (working copy)
@@ -65,7 +65,7 @@

global $wgOut;
$wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
$wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
  • if ( $this->storage->cookiesNeeded() ) {

+ if ( CaptchaStore::get()->cookiesNeeded() ) {

     $wgOut->addWikiText( wfMsg( 'captchahelp-cookies-needed' ) );
  }
}

</pre>

Thank you for having a look at this. Cheers

[1] http://www.mediawiki.org/wiki/Extension_talk:ConfirmEdit#x.5BQuestyCaptcha.5D_Help_page_on_1.18_is_broken_8574


Version: unspecified
Severity: normal

Details

Reference
bz32501

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:00 AM
bzimport set Reference to bz32501.
bzimport added a subscriber: Unknown Object (MLST).