Page MenuHomePhabricator

Allow the "See also" field to accept PHP bugs
Closed, ResolvedPublic

Description

It's certainly one tracker we use a lot and would be useful

Currently you get:

http://bugs.php.net/bug.php?id=39451 is not a valid URL to a bug. See Also URLs should point to one of:
show_bug.cgi in a Bugzilla installation.
A bug on launchpad.net
An issue on code.google.com.
A bug on bugs.debian.org.

Might be a config thing (can't see anything obvious), or might need an upstream bug...


Version: unspecified
Severity: enhancement
URL: https://bugzilla.mozilla.org/show_bug.cgi?id=577847
See Also:
https://bugzilla.mozilla.org/show_bug.cgi?id=577847
https://bugzilla.mozilla.org/show_bug.cgi?id=703919

Details

Reference
bz32504

Related Objects

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:01 AM
bzimport set Reference to bz32504.

Upstream bug in Bugzilla:

https://bugzilla.mozilla.org/show_bug.cgi?id=577847

Might be able to hack in some custom validation, don't know if there's a good interface for it.

(In reply to comment #1)

Might be able to hack in some custom validation, don't know if there's a good
interface for it.

A quick look suggests it's going to be a case of changing core files :(

(In reply to comment #3)

Here's a patch:

http://tools.wikimedia.pl/cgi-bin/fossil/timeline?fc&n=20&y=all

http://tools.wikimedia.pl/cgi-bin/fossil/ci/cf05f0d7bc?sbs=0

Yay for upstreaming them.

I'm not sure whether this is worth making core hacks to put in place till it's committed upstream and available in Bugzilla releases

Thanks! Wouldn't hold my breath. First we will have a discussion whether it needs to go into a bundled extension or core; Then it might be backported to the stable branch and later into what we are running in production. Then wait for the release.

You know the process, don't you?:)

(In reply to comment #5)

You know the process, don't you?:)

Have you tried getting stuff enabled on Wikipedia? ;)

An extension would be fine, but when I looked at it before, there was no way to modify the list, so there'd have to be some core hacking at a minimum..

Thehelpfulonewiki wrote:

Reset assignee per bug 37789

as https://bugzilla.mozilla.org/show_bug.cgi?id=735196 has been fixed and we are now upgraded Bugzilla, so maybe this feature is already available for us?

(In reply to comment #8)

maybe this feature is already available for us?

Upstream TM is set to v4.4, we run 4.2. Backporting should be easy though (volunteers welcome) - wikimedia/bugzilla/modifications in Gerrit.

Pushed gerrit change 44393

I need to get access to "bugtracker" group to test it, but it should work easily (I had a patch against 4.0 as well)

uhm..yeah. I merged that code in Gerrit. Then i pushed it on the server and put it in /srv/org/wikimedia/bugzilla/extensions/MoreBugUrl alongside other extensions and let www-data read stuff. But that is it so far.

(In reply to comment #12)

uhm..yeah. I merged that code in Gerrit. Then i pushed it on the server and
put
it in /srv/org/wikimedia/bugzilla/extensions/MoreBugUrl alongside other
extensions and let www-data read stuff. But that is it so far.

I'm confused (and forgot about this ticket, as MoreBugUrl would also support RT links in the "SeeAlso" field which we've patched into Wikimedia Bugzilla in the meantime).
As we have deployed other patches in the meantime and hence have run checksetup.pl, what exactly is left to do here?

eh, i also forgot about this one meanwhile. I guess what is left to do here is to just check if it accepts PHP bugs now. In case it doesn't, let's have a new patch set. But i think it's simply done, because i see those files on the server:

root@kaulen:/srv/org/wikimedia/bugzilla/extensions/MoreBugUrl/lib# ls
GetSatisfaction.pm PHP.pm ReviewBoard.pm Rietveld.pm RT.pm

Something is not properly merged I think since the error message does not even mention <li>A bug on bugs.php.net.</li> (see https://gerrit.wikimedia.org/r/#/c/44393/2/bugzilla-4.2/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl).

This might be caused by the "disabled" file in the extension, see gerrit change 44393 first comment from Andre.

This will automatically be fixed once we've upgraded Bugzilla to 4.4 (I tested it already), hence adding dependency.

PHP bugtracker URLs are supported in "See Also" now that we run Bugzilla 4.4 and its MoreBugUrl extension.