Page MenuHomePhabricator

On Screen Keyboard with Narayam
Closed, DeclinedPublic

Description

Author: pathak.ab

Description:
Patch for initial work on On Screen Keyboard in Narayam

I'm adding an On Screen Keyboard in Narayam.
Its currently partially functional.
Though it needs many improvements on UI and functionality side.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz32518
ReferenceSource BranchDest BranchAuthorTitle
repos/data-engineering/dumps/mediawiki-content-dump!12use-rev-deletedmainxcollazoAdd visibility on backfills via broadcast join of wmf_raw.mediawiki_revision.
toolforge-repos/jouncebot!1work/bd808/gitlab-migrationmainbd808Post-migration updates
Customize query in GitLab

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
DeclinedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:02 AM
bzimport set Reference to bz32518.
bzimport added a subscriber: Unknown Object (MLST).

Couple issues I notice:

  • keyboard.png image is missing
  • there's a lot of code duplication that will complicate maintenance; for instance osk_fetchKeyboardRules mostly consists of the same functions called over and over again on different letters

More generally, I'm a bit unclear on what the on-screen keyboard is meant to do, how it's meant to work, how it's meant to be switched in/out, etc. Do you have some background information about the project you can link to?

sumanah wrote:

For reference, this is part of the work we did in https://www.mediawiki.org/wiki/India_Hackathon_2011 .

sumanah wrote:

Abhijeet, I've marked this patch "reviewed" per Brion's comment 1 -- can you reply to his question?