Page MenuHomePhabricator

Not all the marked sections are recognised
Closed, ResolvedPublic

Description

I followed the instructions from meta [1] to modify the homepage of ro.wp [2]. After that change, only the "Article of the day" and the "News" sections appeared. The rest of the marked sections are invisible.

Device: Nokia 5800, Nokia browser and Opera mini

[1] http://meta.wikimedia.org/wiki/Mobile_Projects/Mobile_Gateway#Mobile_homepage
[2] https://ro.wikipedia.org/w/index.php?title=Pagina_principal%C4%83&action=historysubmit&diff=5856180&oldid=5437667


Version: unspecified
Severity: major

Details

Reference
bz32596

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:07 AM
bzimport set Reference to bz32596.
bzimport added a subscriber: Unknown Object (MLST).

<div if="mf-comunitate" title="Comunitate" style="padding:6px;">

^ needs to be id= not if=

The others look ok offhand, not sure why they don't show...

Well based on http://en.m.wikipedia.org/ only article of the day and in the news get shown at all. Is it configurable or something?

This needs documenting!

Damn... thanks for spotting this Brion. Fixed and the section now shows ok.

(In reply to comment #2)

Well based on http://en.m.wikipedia.org/ only article of the day and in the
news get shown at all. Is it configurable or something?

This needs documenting!

Since the custom section worked, I'm guessing that changing all the other sections to custom ones will work as well. But if this is as designed, the meta page clearly needs updating.

(In reply to comment #2)

Well based on http://en.m.wikipedia.org/ only article of the day and in the
news get shown at all. Is it configurable or something?

It's not configurable. Look at http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/MobileFrontend/MobileFrontend.php?revision=103097&view=markup#l1009 , you only have the 2 sections and the rest are custom.

I think this should remain as a bug, as the other sections are quite common too. THe alternative is to make this an enhancement and update the docs for the time being.

I was never a big fan of the hard coded sections as it really limits what gets shown. Each project should be able to pick whatever they want to display on the main page and not just what we say is ok. Since we didn't want to break all existing pages we opted to leave the old ones and just added a unique new prefix. With this prefix anyone working on the main page can get new content added. This way no project administrator has to ever talk to a dev to add a new section. Lets not make everyones work harder.

As for the docs I guess we could flip the sections so that the global one comes first. It already correctly states what it does 'any selector that is prefixed with mf- will be added to the mobile main page'

(In reply to comment #6)

Lets not make everyones work harder.

I fail to see how does adding fixed sections makes anyone's work harder. This is not about removing the custom sections, but about adding the fixed sections that you've been advertising for the last half year on meta.

As for the docs I guess we could flip the sections so that the global one comes
first. It already correctly states what it does 'any selector that is prefixed
with mf- will be added to the mobile main page'

The [meta] docs are now more or less correct because I changed them. However, many users have already read and applied what existed on meta. You should at least done one of these:

  • come back with a message on each Wikipedia's Village Pump saying: "there was a mistake, please review your homepage"
  • change the wrong main pages yourself. This is much harder, as you have to put the localised titles yourselves.

Has this been deployed already? If not, what version will it be available in?

preilly wrote:

(In reply to comment #8)

Has this been deployed already? If not, what version will it be available in?

Yes, it's been available since Tue Nov 15 00:44:24 2011 UTC (5 months, 1 week ago).