Page MenuHomePhabricator

Special:ExtensionDistributor for REL1_18 version does not include svn:externals
Closed, ResolvedPublic

Description

The documentation, included in the distribution says:

"If you downloaded this from MediaWiki.org, there should already be a 'geshi' directory in this folder. If there is, you can skip the next paragraph."

The documentation at [[mw:Extension:SyntaxHighlight GeSHi]] is clearer:

"Since r46666, we bundle Geshi into subversion. When downloading via the ExtensionDistributor or directly from SVN, there should already be a "geshi" directory inside your SyntaxHighlight_GeSHi directory. If this is the case then GeSHi is already installed."

No such folder exists, 4 files were unzipped: SyntaxHighlight_GeSHi.php, SyntaxHighlight_GeSHi.i18n.php, SyntaxHighlight_GeSHi.class.php, and README.

I downloaded the version for MW1.18 from the ExtensionDistributor. Either something is missing or the documentation is incorrect.


Version: unspecified
Severity: normal

Details

Reference
bz32633

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:59 PM
bzimport set Reference to bz32633.
bzimport added a subscriber: Unknown Object (MLST).

It would look like REL1_18 was checked out ignoring externals

Trunk and 1.17 are fine

from triage: Ops needs to run svn up with externals.

Do you mean that 'svn up' is being run with --ignore-externals option? Why would that be happening?

(In reply to comment #3)

Do you mean that 'svn up' is being run with --ignore-externals option? Why
would that be happening?

I've no idea if that is what is happening, but apparently that would be a way to cause this.

All the files are there in the working copy. The tar file in question was generated a month ago, maybe the files weren't there at the time. I'll delete all the cached tarballs.

Just tried to download again and got the same problem... or was I supposed to wait for something else?

You were supposed to wait for me to finish fixing it, which I have now done.

Right. I was too fast on the trigger. It works now. I just assumed you had already done it.