Page MenuHomePhabricator

Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17
Closed, ResolvedPublic

Description

Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17

And on that note, SkinTemplate still mentions Skin::makeGlobalVariablesScript... It doesn't exist in trunk!


Version: 1.18.x
Severity: normal

Details

Reference
bz32702

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:04 AM
bzimport set Reference to bz32702.
bzimport added a subscriber: Unknown Object (MLST).

from triage, robla asks how hard this it is to restore back compat and says "if it's hard, then I think this becomes a documentation issue. if it's easy, we should at least provide a patch, I think"

mail wrote:

I'm still using a skin with plenty of modifications to the head element. How do I go about using the Skin::makeGlobalVariablesScript (or it's modern variant) without having to switch to using the "$useHeadElement = true" option?