Page MenuHomePhabricator

VipsTest: Wrong image height/width
Closed, ResolvedPublic

Description

Screenshot including firebug

Special:VipsTest sometimes puts the wrong height and width on the div containing the image. Since the overflow is hidden, the result is not pretty. The size appears to be acquired while the image loads. If you refresh the page, the image is already cached by the browser, and the correct size is used.

See attached screenshot.


Version: unspecified
Severity: normal

Attached:

VipsTest-image-size.png (876×1 px, 129 KB)

Details

Reference
bz32720

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:05 AM
bzimport set Reference to bz32720.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

I suspect this happens if the the images are not yet ready when the ucompare initialization function is called. This is because the $(document).ready() does not guarantee all assets to be loaded. We should hook into $(document).load() instead.

Bryan.TongMinh wrote:

Fixed in r104733.

merged in wmf by r104849. Pending deployment.

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM