Page MenuHomePhabricator

Blocked user trying to edit gets an error
Closed, ResolvedPublic

Description

Author: computergeoffrey

Description:
It is fixed in trunk, but a patch is needed for 1.18

Blocked user trying to edit gets an error:
Fatal error: Call to undefined method WebRequest::getIP() in /home/u826247802/public_html/wiki/includes/User.php on line 2942


Version: 1.18.x
Severity: normal

Details

Reference
bz32754
TitleReferenceAuthorSource BranchDest Branch
use flink's AsyncRetryStrategy instead of RetryingAsyncFunctionrepos/search-platform/cirrus-streaming-updater!31pfischerasync-retrymain
Move namespace check down, to not add sidebar link where not usedrepos/commtech/autosuggest-sitelink!39samwilsonno-sidebar-linkmain
Customize query in GitLab

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:07 AM
bzimport set Reference to bz32754.
bzimport added a subscriber: Unknown Object (MLST).

GICodeWarrior wrote:

A User.php change that uses a new WebRequest API (getIP) was backported to 1.18. I asked Geoffrey to try copying the new WebRequest API over and a new error occurred.

A safer/simpler option I overlooked is to replace the new API call with "wfGetIP()".

This is not an issue in trunk (since the new API is there) but should be fixed in the 1.18 branch for the next point release.