Page MenuHomePhabricator

It's difficult to tap into the search box
Closed, DeclinedPublic

Description

I have to do it many times to get it focused. Dunno why.


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz32917
TitleReferenceAuthorSource BranchDest Branch
Rename HTTP_PROXY to HTTPS_PROXYrepos/mediawiki/services/ipoid!152tchandershttps-proxymain
get-feed: Support using a proxy with axiosrepos/mediawiki/services/ipoid!144kharlanT349171-9634main
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:08 AM
bzimport set Reference to bz32917.
bzimport added a subscriber: Unknown Object (MLST).

We fixed a number of issues with the search box not showing a highlight. This should be good now. Please re-open if its still an issue.

(In reply to comment #2)

We fixed a number of issues with the search box not showing a highlight. This
should be good now. Please re-open if its still an issue.

Can you provide an apk somewhere to test?

@liangent: RC3 apk available here (http://dumps.wikimedia.org/android/WikipediaMobile-RC3.apk)

Do subscribe to the WikimediaMobile mailing list, RC announcements (and soon, nightlies!) will be sent out over there.

Reopen.

The exact behavior in RC3 is, when I tap the search box it gets an orange border but no cursor nor onscreen keyboard is shown. after this if I tap the search button (there is no text to search now) then tap the text box again, the text box gets the orange border and cursor, and a keyboard is shown.

My 'absolute' branch resolves this by removing the 'position: fixed' floating toolbar and letting it scroll off the page:
https://github.com/brion/Wikipedia/commits/absolute

This lets us drop the event handlers that screw up the focusing, because we don't need them to work around the bug where click events went through to the background elements.

It also provides more screen space for reading, which is a big plus in portrait orientation where a toolbar eats proportionately more screen space.

We've now moved to a div instead of iframe, which appears to avoid these clickthrough problems.

Can we confirm?

(In reply to comment #7)

We've now moved to a div instead of iframe, which appears to avoid these
clickthrough problems.

Can we confirm?

Now the first tap can give the box a yellow border and set cursor in it. However the soft keyboard doesn't shown up. I have to tap the box again to use the keyboard.

Still problems with this or is it all resolved?