Page MenuHomePhabricator
Create Task
Maniphest T34933

Call to Edit CTA Change orders
Closed, ResolvedPublic
Actions

Description

Here are two requests regarding the Call to Edit CTA:
(what you see when you click on 'Post your feedback' button)

  1. Remove the 'X' Close button

This would only occur when the CTA is at the bottom of the page, not when it is in an overlay mode

  1. Remove the '?' Help button (or link it to the new tutorial)

This can either be done by removing the Help button -- or linking it directly to the tutorial at this URL (same link as for "Learn how to edit"):
http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Tutorial
(note that this only applies to the Call to Edit CTA, not the feedback forms, for which Help should continue to work as intended).

  1. Remove the extra space in this CTA in overlay mode:

When this CTA is shown in overlay mode, it includes about 100 extra pixels at the bottom the CTA form. It should be the same height as when that CTA is shown at the bottom of the page.

Please let us know if you would like us to split this ticket into three separate tickets.

Version: unspecified
Severity: major

Details

Reference
bz32933

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT41042 ArticleFeedbackv5: Phase 1.0 (tracking)
 ResolvedNoneT34933 Call to Edit CTA Change orders

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:59 PM
• bzimport added a project: ArticleFeedbackv5.
• bzimport set Reference to bz32933.
• Fabrice_Florin created this task.Dec 9 2011, 9:23 PM
• bzimport added a comment.Dec 10 2011, 2:23 AM

reha wrote:

  1. Will not fix. You need that button to close the overlay and look at the article again.
  1. Fixed in r105746
  1. Fixed in r105744

One ticket per request, please!

• Fabrice_Florin added a comment.Dec 10 2011, 3:30 AM

Thanks, Reha!

I will start separating out my requests into different tickets, as you propose.

But isn't the first item an reasonable request for when the call to action is at the bottom of the page? The idea is that we wouldn't show the 'X' button when the form is at the bottom of the page -- only when it is shown in overlay mode, as we do with the feedback forms.

This is not a top-priority, so we can revisit later, but wanted to make sure we're talking about the same issue.

Fabrice

• bzimport added a comment.Dec 10 2011, 6:02 AM

reha wrote:

Wow, I need my eyes checked! I saw that the other way around -- as if we should leave it at the bottom of the page, drop it from the overlay.

The close button on the CTA when at the bottom of the page was specifically requested -- it was #47 on our internal tracker, added last week by Yoni -- so that the user could remove the CTA from the page entirely. I believe it was around the same time we started removing the feedback link(s) on submit.

Could we maybe put together a flowchart of what needs to change on the page after submit, and when the user closes the CTA?

• bzimport added a comment.Dec 10 2011, 6:03 AM

reha wrote:

(or just a list, rather; a flowchart is probably overkill!)

• Fabrice_Florin added a comment.Dec 10 2011, 8:00 PM

I don't remember asking for a close button on the Edit CTA when it is in the bottom of the page.

Yoni, can you clarify where this request came from? This is not a real show-stopper, but I want to track how it came about.

For now, I am going to reopen this ticket, so it remains on our radar.

Your idea of a flowchart/list is a good one. Let's try to do this in coming days.

• Fabrice_Florin added a comment.Dec 12 2011, 5:07 PM
  • Bug 32966 has been marked as a duplicate of this bug. ***
• Fabrice_Florin added a comment.Dec 12 2011, 5:10 PM
  • Bug 32940 has been marked as a duplicate of this bug. ***
• Fabrice_Florin added a comment.Dec 13 2011, 4:36 AM

This problem still exists on Monday's prototype.

The Help button should be removed.

The Close button should NOT be shown when the form is at the bottom of the page, only when it is in overlay mode.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL