SpecialAllMessages: input form doesn't show and remember filter option
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MrBlueSky
	Dec 10 2011, 10:44 PM

Description

Patch against trunk

Goto for example https://en.wikipedia.org/wiki/Special:AllMessages. Next to "Filter by customisation state" no radiobutton is checked. Choose 'modified' or 'unmodified' and click go: again no radiobutton is checked. Clicking go again defaults to showing all messages instead of the selected filter.

This happens in 1.18 and 1.19.

Its because class AllmessagesTablePager uses $this->filter to set the radiobuttons instead of $this->custom.

Version: 1.20.x
Severity: normal

Attached:

sysmsg_filter.patch925 BDownload

Details

Reference: bz32958

	Title	Reference	Author	Source Branch	Dest Branch
	jenkins-rel: remove GitHub plugins	repos/releng/jenkins-deploy!44	jnuche	remove-github-plugins	master

Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:00 AM

• bzimport added a project: MediaWiki-Special-pages.

• bzimport set Reference to bz32958.

• bzimport added a subscriber: Unknown Object (MLST).

MrBlueSky created this task.Dec 10 2011, 10:44 PM

Done slightly differently on trunk in r105853 -- tagging for 1.18, 1.18wmf1 merge. Looks like something probably broke during a refactor and a var didn't get hoisted down to the tablepager class.

Good catch, and thanks for the report & patch!

SpecialAllMessages: input form doesn't show and remember filter optionClosed, ResolvedPublicActions

Description

Details

Event Timeline

SpecialAllMessages: input form doesn't show and remember filter option
Closed, ResolvedPublic
Actions