Page MenuHomePhabricator

Undeletion should allow for an edit summary
Closed, ResolvedPublic

Description

Author: p_simoons

Description:
Since undeletion is basically undoing another admin's action, it would be nice
if it were possible to enter an edit summary when undeleting anything. This
would then show up in the deletion log, along with the edit summaries for
deleting things. E.g. "history undeletion", or "VFU consensus" or "misreading of
CSD#G3".

Presently admins tend to perform a null edit after undeletion in order to
present their reasoning, if they want. But those don't appear in the deletion
log, of course.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Special:Undelete

Details

Reference
bz3309

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:48 PM
bzimport set Reference to bz3309.

phroziac wrote:

*** Bug 3372 has been marked as a duplicate of this bug. ***

robchur wrote:

Patch from Phroziac over on the other bug; uploading here in appropriate format

Attached:

robchur wrote:

Patch from Phroziac over on the other bug; uploading here in appropriate format (part two)

Attached:

This patch mixes UI code into the backend; needs a little work.

The UndeleteForm class should be checking the request for variables, and then pass the
reason if given on to the backend class PageArchive. PageArchive could be used in a
batch operation or other specialized case, so you should not assume that $wgRequest
will belong to an UndeleteForm in the other class.

It would probably be good also to be consistent about the form field naming; this form
seems to be using mostly plain names, so 'reason' might be better than 'mReason'.

robchur wrote:

Added in SVN trunk, r14090.