Page MenuHomePhabricator

LocalisationUpdate not updating FlaggedRevs messages
Closed, ResolvedPublic

Description

Author: beau

Description:
Localised messages were reverted to the old ones. For example
Message displayed yesterday (it is in trunk):

'flaggedrevs-hidereviewed' => '$1 przejrzane edycje',

Message displayed today (it is in 18wmf1
'flaggedrevs-hidereviewed' => '$1 ukrytych edycji',

File: extensions/FlaggedRevs/presentation/language/FlaggedRevs.i18n.php

This issue may be caused by failed localisation update today https://wikitech.wikimedia.org/view/Server_admin_log#December_14


Version: unspecified
Severity: normal

Details

Reference
bz33122
TitleReferenceAuthorSource BranchDest Branch
Do not require extension.json schema changesrepos/growth/community-configuration-example!2urbanecmextension-attributesmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:02 AM
bzimport added projects: Deployments, I18n.
bzimport set Reference to bz33122.
bzimport added a subscriber: Unknown Object (MLST).

low priority because I suspect the problem is intermittent. Please correct me if I'm wrong, Roan.

Problem is that some of this text are on (for example) RecentChanges

http://pl.wikipedia.org/wiki/Specjalna:Ostatnie_zmiany

"Ukryj ukrytych edycji" - this is very incorrect.

This is not an intermittent problem, it's because LocalisationUpdate is getting confused by the fact that the FlaggedRevs i18n files were moved.

Aaron (CC), is there anything we can do to make the i18n file paths for FlaggedRevs match in trunk and 1.18wmf1?

What error is it giving? I know a symlink was put up a while ago to help this.

(In reply to comment #4)

What error is it giving? I know a symlink was put up a while ago to help this.

PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ConfiguredPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ConfiguredPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ConfiguredPages.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/FlaggedRevs.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/FlaggedRevs.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/FlaggedRevs.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/PendingChanges.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/PendingChanges.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/PendingChanges.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ProblemChanges.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ProblemChanges.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ProblemChanges.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/QualityOversight.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/QualityOversight.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/QualityOversight.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedPages.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedVersions.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedVersions.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ReviewedVersions.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/Stabilization.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/Stabilization.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/Stabilization.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/StablePages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/Stabilization.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/Stabilization.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/StablePages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/StablePages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/StablePages.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/UnreviewedPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/UnreviewedPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/UnreviewedPages.i18n.php
PHP Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ValidationStatistics.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ValidationStatistics.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301
Cannot get the contents of /var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ValidationStatistics.i18n.php

This is caused by r102741 which renamed "presentation" directory to "frontend". There is more discussion on r104088, but it seems that the symlink solution does not work. As of r107515 running on Wed Dec 28 23:54:10 UTC 2011 on Wikimedia (plwiki) we still have a problem.

Bumping importance to "High", as some messages on live site look really strange.

Aaron - Any reason we can't just push a trunk version of FR into 1.18wmf1? Seems the easiest way to make it consistent, and probably the quickest rather than a load of debugging what ifs...

If so, which rev can we branch from? Or can we take SVN HEAD?

(In reply to comment #7)

Aaron - Any reason we can't just push a trunk version of FR into 1.18wmf1?
Seems the easiest way to make it consistent, and probably the quickest rather
than a load of debugging what ifs...

If so, which rev can we branch from? Or can we take SVN HEAD?

Aaron suggests with a small amount of CR, we can branch FR as of r104562 into 1.18wmf1

(In reply to comment #8)

(In reply to comment #7)

Aaron - Any reason we can't just push a trunk version of FR into 1.18wmf1?
Seems the easiest way to make it consistent, and probably the quickest rather
than a load of debugging what ifs...

If so, which rev can we branch from? Or can we take SVN HEAD?

Aaron suggests with a small amount of CR, we can branch FR as of r104562 into
1.18wmf1

https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FFlaggedRevs&title=Special%3ACode%2FMediaWiki%2Fstatus%2Fnew

Created attachment 9799
Diff from r98024 (last successful import) till head

This diff describes changes to the FlaggedRevs since the last successful merge of i18n (I think tha r98023 was merged in r98144)

Attached:

Created attachment 9800
Changes to FlaggedRevs messages since r98023

This diff describes changes to the FlaggedRevs i18n MESSAGES ONLY since the last successful merge of i18n (I think tha r98023 was merged in r98144)

Attached:

I have briefly analized the changes to FlaggedRevs messages since r98023, and it seem that there were only the following changes to the messages:

  • bokmål has been changed from Nb to No (r107287, unfortunately with some other changes as well)
  • I have removed "revreview-cancel" function in r99182 (trivial to backport)

The message "flaggedrevs-hidereviewed" was changed for Polish in r99033, so merging this into the deployed version is of the highest priority (previous translation was very bad).

  • bokmål has been changed from Nb to No (r107287, unfortunately with some other

changes as well)

sorry, it was no->nb

How are /var/lib/l10nupdate/ files generated? Maybe a simple "mv" there would do?

(In reply to comment #14)

How are /var/lib/l10nupdate/ files generated? Maybe a simple "mv" there would
do?

It's a svn checkout

So moving stuff will just cause future conflicts

Verified: works. Removed workaround on plwiki. Thank you!