Page MenuHomePhabricator

Make Special:Popularpages includable
Closed, InvalidPublic

Description

It shoudl be possible to include Special:Popularpages, e.g. {{Special:Popularpages/25}}

WikiMedia has the hit counter disabled, but this would be an easy way to return the most popular pages on Main Page as quick navigation help.


Version: unspecified
Severity: enhancement

Details

Reference
bz33160
ReferenceSource BranchDest BranchAuthorTitle
repos/releng/scap!197master-I0d41d2d71080c491cb9622819e0063d01d5da9ecmasterdancyTests: Always run shellcheck, pytest, flake8, black, and sphinx-build
repos/releng/scap!196master-I43285c3674b1144f260ddc2b3207360b2ffc95d1masterdancyReformat sources using black
repos/releng/scap!195master-I3cf0e8264fc24ec460e7c998ed45c2bb09ca4e93masterdancyAdd 'black' to test-requirements.txt
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33160.
bzimport added a subscriber: Unknown Object (MLST).

ashwini7security wrote:

This is how we can create magic page in mediawiki

you have to do one modification is your Specialpopularpages.php.

which is in your mediawiki installation
just go to include/special/specialpopularpages.php

#now you have to jjust edit one line in your _contruct() that is
$this->mIncludable = true;

then create new page "Magicpage" and enter this line in that

{{Special:PopularPages}}

save it
and you done !
now go to your magicpage

Attached:

sumanah wrote:

Added "patch" and "need-review" keywords.

Nice first patch, Ashwini. Thank you very much!

Problem here is that when this page is transcluded, the paging elements are also still on the transcluded text. Please improve the patch by only adding the content, and not the paging controls.

Another thing that is not implemented, but requested here, is the limit for the number of popular pages displayed.

I updated the patch to reviewed, but in this state, it cannot be committed.

see https://gerrit.wikimedia.org/r/#/c/107979

There is an "extension" for it on [[mw:Extension:TopTenPages]] - it isn't well maintained and it will be better to include such feature in mw-core.

Change 107979 had a related patch set uploaded by Brian Wolff:
Make Popularpages includeable

https://gerrit.wikimedia.org/r/107979

(In reply to comment #5)

Change 107979 had a related patch set uploaded by Brian Wolff:

gerrit bot lies, it wasn't uploaded by me.


Part of me wonders if we should just make all QueryPages transcludable.

Umherirrender claimed this task.

Special pages was removed with I0e5006a7e8a09c800f8fa4effa9399e8afdd7a57 - https://gerrit.wikimedia.org/r/#/c/150699/

Umherirrender set Security to None.