Page MenuHomePhabricator

WebFonts aren't applied to Fundraising banners
Closed, DeclinedPublic

Description

It appears that WebFonts aren't applied to Fundraising banners. Try the URL in Google Chrome - i uninstalled the Lohit Oriya font, and now i see squares there. Firefox successfully loads a fallback font, but Chrome doesn't. Check also font-family in the computed style in the developer tools of your browsers: Lohit Oriya is applied to elements in the body of the page, but not to the banner.


Version: unspecified
Severity: normal
URL: http://or.wikipedia.org/wiki/Main_Page?banner=B11_Donate_SusanAccept

Details

Reference
bz33190

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:07 AM
bzimport set Reference to bz33190.
bzimport added a subscriber: Unknown Object (MLST).

#B11_Donate_SusanAccept #cn-bold-blue-text {

color: navy;
font-family: Helvetica,Arial,sans-serif;

...
}

WebFonts will identify that the text got an already defined font-family style - Helvetica, Arial, sans-serif. And it will not override it.

Is the proper fix to remove those font-family bits, or to add the expected webfont names into the font-family in the banners?

If it's possible to remove them, it would probably be the simplest and the most correct thing to. I asked Jon Harald to check whether it's possible to just remove them. Maybe the Fundraising team had a reason to put them in.

Comment - the bug only shows itself in Chrome if the Lohit Oriya font is not installed locally.

Sure this exists now?

I dont have any Oriya font on my Win XP machine and on chrome without WebFonts I see squares everywhere incl banners, but with Lohit-Oriya, am able to see things incl banners (jimmy's one now)

Srikanth, do you see it in Google Chrome? I still see it.

This is probably not a bug in MediaWiki, but in the design of the banners. Unless there's a good reason to specify "Helvetica,Arial" explicitly, it should be removed.

Amir, Sorry for confusion, I think comment 5 was because of a bug 33396 in Chrome.

attachment 9773 shows Banner rendering properly with WebFonts. but comment 5 may not hold water since I have some Oriya font installed on my machine.

Can you also check if there are differences in banners? (The jimmy one and the one you are getting)

There are many Jimmy banners, but in [1] there is no explicit font-family definition on the #cn-bold-blue-text element and the Oriya fonts appear correctly.

(This banner seems to have a different bug, saying "NaN Cr" instead of the real number of crores; i'll report it.)

[1] http://or.wikipedia.org/wiki/Main_Page?banner=B11_Donate_Projects_ThermoLimited_IN

Lowering the priority since this issue does not have any immediate impact.

If this is something that is be a problem in CentralNotice, then
priority should be raised again.