Page MenuHomePhabricator

News icon shown for news:// should also apply to news: URLs
Closed, ResolvedPublic

Description

The main CSS has rules for external link icons based on recognizing URI schemes. For example, the http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=ext.wikihiero%7Cmediawiki.legacy.commonPrint%2Cshared%7Cskins.vector&only=styles&skin=vector&* main Vector CSS has a rule for news:// so that it creates a link and an icon.

As I see it, per RfC 5538, the URI scheme can be either news:// or news:but the latter is not supported by the CSS. Looks to me like the CSS should be updated to support news: which would support both schemes.


Version: 1.18.x
Severity: minor

Details

Reference
bz33246

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:59 PM
bzimport set Reference to bz33246.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 9739
Patch for vector/screen.css

Changed CSS selector from "news://" to "news:".

attachment screen.css.news-url.patch ignored as obsolete

Created attachment 9740
Patch for vectror/screen.css

Attached:

Created attachment 9741
Patch for monobook/main.css

Attached:

Created attachment 9742
Patch for modern/main.css

Attached: