Page MenuHomePhabricator

ACCEL+K should NOT activate the Link Window
Closed, InvalidPublic

Description

Currently, hitting <control> or <command> + K in the Visual Editor opens a link dialog. This is sub-optimal, as <control>-k is (and has been, for about 30 years) the "kill" command in emacs-like editors. (<ctrl>-k adds to the kill ring, <ctrl>-y pastes the kill ring into the contents).

I suggest that the Visual Editor should support these basic commands by default, without modification via preferences (e.g., "use emacs keybindings"). Activation of the link editor should probably be moved to a more intuitive accelerator anyways ("k" does not suggest "link" to me).

For implementation, the "kill ring" functionality operates thus: <ctrl>-k deletes the current line of text, including the EOL character. This text is copied into the "kill ring" buffer. Additional <ctrl>-k expressions ''add'' to the kill ring; ''any'' other activity (including cursor movement) "closes" the kill ring. At that point, <ctrl>-y will insert the entire contents of the kill ring into the text at the point of the cursor.


Version: unspecified
Severity: normal

Details

Reference
bz33267
TitleReferenceAuthorSource BranchDest Branch
Update analytics session_length DAGrepos/data-engineering/airflow-dags!608joalfix_session_length_icebergmain
Migrate session length to Icebergrepos/data-engineering/airflow-dags!600aquT352672_session_length_icebergmain
Add iceberg version of interlanguage_daily dagrepos/data-engineering/airflow-dags!590tchininterlanguage-icebergmain
Update browser_general dag to generate iceberg tablerepos/data-engineering/airflow-dags!576ebysansbrowser_general_icebergmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:01 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz33267.
bzimport added a subscriber: Unknown Object (MLST).

Common rich-text editors like Google Docs and Microsoft Word. Emacs keybindings should not and will not be inherited or maneuvered around.

Sorry if that last post was incoherent - I meant to say "Common rich-text editors like Google Docs and Microsoft Word all use command+K for hyperlinks"

That's actually a pretty good reason, though I don't necessarily think we should look to either of those applications for overall design cues.

I'm going to close this.

Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.