Page MenuHomePhabricator
Create Task
Maniphest T35322

Submitting a clicked search suggestion is broken: Backport r100348 to 1.18
Closed, ResolvedPublic
Actions

Description

I did an update to MW 1.18 and now I have a problem with the search suggestions:
The suggestions appear and when I click one, the text is filled into the search box.

However, the form is not submitted. So the according page is not loaded anymore. This worked correctly in MW 1.17.

I can reproduce this bug with several skins: With Vector and with MonoBook and with a custom skin, which is based in Vector.

I have tested the following browser:
The issue is present in FF8 and FF9.
It is not present in IE8, Opera and Chrome.

Version: 1.18.x
Severity: normal
Platform: PC

Details

Reference
bz33322

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 12:05 AM
• bzimport added a project: MediaWiki-Search.
• bzimport set Reference to bz33322.
• bzimport added a subscriber: Unknown Object (MLST).
Joergi123 created this task.Dec 22 2011, 3:35 PM
MarkAHershberger added a comment.Dec 22 2011, 6:37 PM

Just noting that I tested FF, Opera and Chrome when Joerg brought this up in IRC and saw exactly what he is talking about. I didn't see any errors in firebug.

• brion added a comment.Dec 23 2011, 12:10 AM

I can't reproduce this in Firefox 8.0.2 with 1.18 or trunk.

Steps:

  • go to wiki's main page
  • click in search form
  • type 'special:'
  • click one of the results

Expected result:

  • page navigates to the selected special: page

Actual result:

  • as expected
Schnark added a comment.Dec 23 2011, 11:29 AM

This is bug 31602. Not marking as duplicate in the hope that you backport r100348 before closing this bug.

Joergi123 added a comment.Dec 23 2011, 12:23 PM

Hi Michael,

yes, r100348 fixes the issue for me.

This is an anoying bug. If you plan to have another 1.18.x release, I would highly appreciate a backport!
I have just checked it in my 1.18 installation and it is working. :-)

MarkAHershberger added a comment.Dec 23 2011, 8:04 PM

(In reply to comment #3)

This is bug 31602. Not marking as duplicate in the hope that you backport
r100348 before closing this bug.

Thanks for pointing that out. I thought I had marked it for back porting before, but obviously not.

• Cmcmahon added a comment.Mar 5 2013, 5:50 PM

Closing, this seems to have been done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL