Page MenuHomePhabricator
Create Task
Maniphest T35334

Remove database column page.page_restrictions from MediaWiki core
Closed, ResolvedPublic
Actions

Description

The field of page_restrictions of page table is superseded by the page_restriction table. Please remove that field to keep the database schema clean. Thanks.

Details

Reference
bz33334
SubjectRepoBranchLines +/-
schema: Drop legacy page_restrictions in page tablemediawiki/coremaster+287 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:06 AM
• bzimport added projects: MediaWiki-libs-Rdbms, good first task, Schema-change.
• bzimport set Reference to bz33334.
duplicatebug created this task.Dec 22 2011, 7:45 PM
duplicatebug added a comment.Dec 22 2011, 7:57 PM

Yah, the table is called "page_restrictions", the same as the field in page table.

• MZMcBride added a comment.Dec 18 2013, 10:31 PM

I think it should be fairly easy to remove page.page_restrictions. It just requires a few schema patches, as I recall.

Tinaj1234 added a comment.Jan 14 2014, 12:15 PM

Can I work on this?

Tinaj1234 added a comment.Jan 16 2014, 12:56 PM

I prepared the schema patches but I'm confused as to what is to be done with Title::loadRestrictionsFromRows which compiles page restrictions from both page table and page_restrictions table. There are many occurences of page_restrictions in WikiPage.php. Should all that be removed?

gerritbot added a comment.Jan 18 2014, 4:01 PM

Change 108219 had a related patch set uploaded by Tinaj1234:
Removing page_restrictions from page table

https://gerrit.wikimedia.org/r/108219

duplicatebug unsubscribed.Dec 13 2014, 4:18 PM
Umherirrender mentioned this in T86342: Dropping page.page_no_title_convert on wmf databases.Jan 9 2015, 9:07 PM
Platonides subscribed.Jan 9 2015, 9:12 PM

Existing entries in page_restriction field should be migrated to the page_restriction table.

Anomie added a parent task: T30751: prop=info&inprop=protection sometimes shows protection multiple times.Feb 20 2015, 6:41 PM
Tinaj1234 removed Tinaj1234 as the assignee of this task.Oct 1 2015, 11:17 AM
Tinaj1234 set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 11:17 AM
Devirk subscribed.Oct 1 2015, 11:38 AM
Devirk unsubscribed.Nov 21 2015, 2:48 PM
Ricordisamoa subscribed.Dec 15 2015, 9:49 PM
Danny_B moved this task from Unsorted to Delete / Drop / Remove on the Schema-change board.Apr 29 2016, 10:25 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 29 2016, 10:25 PM
• Mattflaschen-WMF created subtask T166184: Run updateRestrictions.php on WMF wikis.May 23 2017, 10:43 PM
• Mattflaschen-WMF removed a project: good first task.May 23 2017, 10:47 PM
• Mattflaschen-WMF subscribed.
In T35334#966927, @Platonides wrote:

Existing entries in page_restriction field should be migrated to the page_restriction table.

There is a script for this, updateRestrictions.php, which is run by update.php.

It looks like the part not done already is removing the column, both as a patch and from tables.sql.

Reedy closed subtask T166184: Run updateRestrictions.php on WMF wikis as Resolved.Jul 19 2017, 8:23 PM
Krinkle moved this task from Untriaged to Schema changes on the MediaWiki-libs-Rdbms board.Jul 28 2018, 10:09 PM
Krinkle mentioned this in T218446: Remove use of legacy page.page_restrictions field.Jul 18 2019, 9:30 PM
Krinkle added a subtask: T218446: Remove use of legacy page.page_restrictions field.
Krinkle changed the task status from Open to Stalled.Jul 18 2019, 9:40 PM
Krinkle subscribed.

Read queries should be removed before the schema patch, preferably in a separate patch.

Krinkle edited projects, added MediaWiki-General; removed MediaWiki-libs-Rdbms.Jul 18 2019, 9:42 PM
Krinkle updated the task description. (Show Details)
ArielGlenn mentioned this in T251411: page_restrictions field incomplete in current and historical dumps.May 2 2020, 5:16 PM
ArielGlenn added a parent task: T251411: page_restrictions field incomplete in current and historical dumps.May 5 2020, 6:33 AM
TerraCodes unsubscribed.May 7 2020, 4:42 AM
Ladsgroup changed the task status from Stalled to Open.May 24 2022, 8:40 AM
Ladsgroup claimed this task.
Ladsgroup closed subtask T218446: Remove use of legacy page.page_restrictions field as Resolved.
Ladsgroup edited projects, added DBA; removed Patch-For-Review.
Ladsgroup subscribed.

Doing it.

gerritbot added a comment.May 24 2022, 8:52 AM

Change 798445 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] schema: Drop legacy page_restrictions in page table

https://gerrit.wikimedia.org/r/798445

gerritbot added a project: Patch-For-Review.May 24 2022, 8:52 AM
• Marostegui moved this task from Triage to In progress on the DBA board.May 26 2022, 5:33 AM
gerritbot added a comment.May 26 2022, 12:42 PM

Change 798445 merged by jenkins-bot:

[mediawiki/core@master] schema: Drop legacy page_restrictions in page table

https://gerrit.wikimedia.org/r/798445

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 26 2022, 1:00 PM
Ladsgroup closed this task as Resolved.May 26 2022, 1:23 PM
Ladsgroup moved this task from In progress to Done on the DBA board.
Zabe subscribed.May 29 2022, 12:03 PM

LiquidThread still selects that column, now causing fatals: T309460.

Ladsgroup added a comment.May 29 2022, 9:59 PM

Sorry about that. Will fix it. I'm sure we didn't have any data loss, it's just fatals.

Krinkle mentioned this in T310225: mw1415 fatals due to serving responses from 1.39.0-wmf.10 (was DBQueryError: Unknown column page_restrictions).Jun 8 2022, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL