Page MenuHomePhabricator

No progress after upload warnings
Closed, ResolvedPublic

Description

Go to http://commons.wikimedia.org/wiki/Special:Upload
Choose a file, set as name "[[É]].jpg" and press Upload.

You get a warning that the name has been changed to «--É--.jpg», please modify the description and try again, and three buttons:

  • Send modified description (the description wasn't at fault, it was the filename, which wasn't modified in the input)
  • Ignore warning and upload anyway (this is not ignorable!)

All of those buttons send you back to the original Special:Upload (although with the fields prefilled) instead of finishing the upload from the stash.

Same error if the warning instead of coming from the filename was due to uploading a duplicate.


Version: 1.18.x
Severity: normal

Details

Reference
bz33357
TitleReferenceAuthorSource BranchDest Branch
builds-builder: bump to 0.0.86-20240111144206-9d0deb2drepos/cloud/toolforge/toolforge-deploy!172project_1317_bot_df3177307bed93c3f34e421e26c86e38bump_builds-buildermain
inject_buildpacks: add clojure backrepos/cloud/toolforge/builds-builder!26dcaroadd_clojure_buildpackmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:07 AM
bzimport set Reference to bz33357.
bzimport added a subscriber: Unknown Object (MLST).

hersfoldwiki wrote:

I just noticed this bug on the internal wiki my team at work uses. Has this been looked at by any developers?

It seems as though any warnings do this. You can also duplicate this bug by uploading a non-preferred and non-blacklisted file when $wgStrictFileExtensions is set to false, or by attempting to upload a previously deleted file, or by attempting to upload a new file to the same name as a previously deleted file - take your pick. My guess is that the processing for the "upload warnings" form isn't properly checking the values of the submit buttons, and is rigged to default to "cancel upload".

Is this the same as bug 26214?

matmarex subscribed.

I can't reproduce this today. There are still two buttons to complete the upload, which is a bit silly (no need to override warnings if the warning was already automagically fixed), but either of them works.