Page MenuHomePhabricator

Intermittent off-by-one in "Read in..." language selection on ICS (Android 4.0)
Closed, ResolvedPublic

Description

Seems to happen fairly often on my Galaxy Nexus (Android 4.0.2), but can't reproduce on a Nexus One (Android 2.3.6).

When selecting a language from the "Read in..." menu, about half the time it's coming back with the next language in the list -- for instance selecting Turkish and getting Vietnamese.

May be a freak weird thing, or something odd about the events and scrolling or something.


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz33615

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:04 AM
bzimport set Reference to bz33615.

Not scrolling related that I can see; happens when nothing is being scrolled.

Seems to just be sending 'click' events to the next <a> in the list when you tap near the bottom of one of the links...

Touchstart/touchend events, and the :hover pseudoclass that's used to highlight, don't seem to see this special case, so it's showing highlighting for the one above but clicking the one below. Nasty!

https://github.com/brion/Wikipedia/commits/touch-work
^ attempts to use touchstart/touchend events instead of click to avoid the bug. Works, but breaks scrolling on Android 2.3.x.

This also happens in the 'saved pages' and 'history' lists.

philinje wrote:

Is this dependent on fixes in ICS?

'Fixed' in ac85f57ceae4c20112207d2655 by getting rid of the touch highlights. Thanks to Gaurav for the patch!