Page MenuHomePhabricator

File errors shown at Special:MovePage and Special:Upload are displayed wrongly
Closed, ResolvedPublic

Description

Any file operation error at Special:MovePage give "permission errors" which are wrongly formatted.

Example:
"You do not have permission to move this page, for the following reason:

<swift-local-backend-pmtpa> "

Likewise, at Special:Upload I get things like:

"Internal error
Jump to: navigation, search

Error storing file in 'C:\wamp\tmp\phpE1C0.tmp': backend-fail-connect; swift-local-backend-pmtpa"


Version: 1.20.x
Severity: normal

Details

Reference
bz33846

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:08 AM
bzimport set Reference to bz33846.

ibaker wrote:

The second case seems to be an issue around line 215 of includes/upload/UploadStash.php where the message isn't being expanded. I'm hesitant to make any changes until I have the first case figured out, though.

In the first case, it seems the errors array being passed back to Title::getUserPermissionsErrorsInternal() is incorrect. "swift-local-backend-pmtpa" appears to be the name of the filestore, and not a message.

After talking with Aaron and Mark, I'm bumping down the priority. This is an error formatting problem rather than a new error.

Fixed sp:MovePage in r110687.

ibaker wrote:

Fixed for UploadStash in r110979

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM
Restricted Application added a subscriber: Matanya. · View Herald Transcript