Page MenuHomePhabricator

WikiEditor crashes Internet Explorer 8 due to bad preferences (might be fixed by newer jQuery)
Closed, DeclinedPublic

Description

After enabling WikiEditor on our MediaWiki 1.17.1 system, a small number of users are experiencing browser crashes in IE8. (The whole browser hangs as WikiEditor is rendering.)

The solution has been to visit My Preferences and simply click the Save button. After that, no more crashes.

Any ideas what could be causing this?

As an experiment, I set my own preferences to be equal to those of a "crashing" user. My browser did not crash.

Here are the preferences for the crashing user, before the "re-save":

select * from vpw_user_properties where up_user = 56;
+---------+----------------------------------+-------------+

up_userup_propertyup_value

+---------+----------------------------------+-------------+

56categorysortdisable0
56cyanrss0
56editwidth0
56enotifminoredits0
56nicknameMike Smith
56officetoolbarbuttons-enable-word1
56rememberpassword1
56searchNs100
56searchNs1000
56searchNs2040
56searchNs2050
56searchNs2061
56searchNs2071
56shownumberswatching0
56skinmonobook
56sqltagdisable0
56timecorrectionSystem-240
56usebetatoolbar1
56usebetatoolbar-cgd1
56variant
56vp-wikieditor-switched1
56wikieditor-preview1

+---------+----------------------------------+-------------+
22 rows in set (0.00 sec)

Here they are after re-saving preferences:

select * from vpw_user_properties where up_user= 56;
+---------+--------------------+-------------+

up_userup_propertyup_value

+---------+--------------------+-------------+

56enotifminoredits
56nicknameMike Smith
56recencylimit
56rememberpassword1
56searchNs10
56searchNs100
56searchNs204
56searchNs205
56searchNs2061
56searchNs2071
56timecorrectionSystem-240
56usebetatoolbar1
56usebetatoolbar-cgd1
56vp-sqlprefstatic
56watchlisttoken
56wikieditor-preview1

+---------+--------------------+-------------+
16 rows in set (0.00 sec)

You'll see a few custom preferences, but I don't see why WikiEditor would pay any attention to them.


Version: REL1_19-branch
Severity: normal
Whiteboard: aklapper-moreinfo

Details

Reference
bz33926

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:04 AM
bzimport set Reference to bz33926.
bzimport added a subscriber: Unknown Object (MLST).

I'd suspect of jQuery, looks similar to http://bugs.jquery.com/ticket/9823
However, that was a bug of jQuery 1.6.2, and MediaWiki 1.17.1 came with v1.4.2 (version is listed at the top of resources/jquery/jquery.js)

MediaWiki 1.19 will ship jQuery 1.7.1 (at least), so might not be an issue anymore.

I'm guessing Platonides is right here. Dan, can you look at what version(s) of jQuery you are using and report them here?

It's the version of jQuery supplied with MediaWiki 1.17.1, which is jQuery 1.4.2.

I've seen a report in mediawiki-l that this problem still exists in 1.19.2.

holtzermann17 wrote:

This bug appears to affect users on Chrome 23.0.1271.64 as well.

I guess we can mark this bug as wontfix since it applied on 1.17.

I advise against wontfix. See comment 5 -- it seems to be present in 1.19.2 also. The poster followed the original instructions to save preferences and it went away, so it's very likely the same problem.

Would be also interesting to know whether IE8 users have "Compatibility mode" enabled, as other reports imply that this is a main source of issues.

holtzermann17 wrote:

FYI problems for Chrome users seem to go away after I updated jQuery.

So it's currently with which exact version of JQuery (and Mediawiki 1.19.2, according to comment 5) this happens.
Dan: Any idea?

If nobody can really reproduce the issue nowadays and provide specific version data, this ticket might end up as WORKSFORME soon.

I haven't seen this problem since we upgraded to MW 1.20 (jQuery 1.8.2) a few months ago.