Global function wfHttpError() is only used in core by AjaxDispatcher. It should be deprecated and callers should use the HttpError exception instead.
Version: 1.20.x
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz34151
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Add banana checker for i18n messages | repos/commtech/wishlist-intake!24 | samwilson | banana-checker | main | |
| Add remaining i18n messages | repos/commtech/wishlist-intake!12 | samwilson | i18n-msgs | main | |
| Add i18n system and start l10n | repos/commtech/wishlist-intake!5 | samwilson | i18n-setup | main | |
| charts: handle concurrent chart downloads | repos/qte/catalyst/catalyst-api!8 | jnuche | T361516-3 | main | |
| use dinamically downloaded charts instead of a Git submodule | repos/qte/catalyst/catalyst-api!7 | jnuche | T361516-2 | main | |
| support latest version of the `mediawiki` chart | repos/qte/catalyst/catalyst-api!6 | jnuche | T361516 | main | |
| adapt chart to reflect latest design of Catalyst API | repos/qte/catalyst/ci-charts!6 | jnuche | T361516 | main | |
| Update wikimediaci-utils to 1.3.0 | repos/ci-tools/libup!30 | taavi | taavi/ciutils | master | |
| Replace Redis queue with custom http solution | toolforge-repos/wikibugs2!28 | bd808 | work/bd808/sse | main | |
| Dependency bumps, etc | repos/ci-tools/libup!29 | taavi | taavi/run | master |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Declined | None | T36151 Turn wfHttpError() into a wrapper for HttpError exception |
Event Timeline
Comment Actions
(In reply to comment #1)
Additionally, we want to avoid loosing time on old stuff (example: r110486 )
Still would've lost time, since the exception still mentions HTML2 as well ;-)
Comment Actions
I like Chad's suggestion in r110486 better. We shouldn't deprecate things that are easy enough to support with a wrapper.
Comment Actions
(In reply to comment #2)
Still would've lost time, since the exception still mentions HTML2 as well ;-)
Exception DOCTYPE fixed with https://gerrit.wikimedia.org/r/5423
Comment Actions
Made wfHttpError() thrown an HttpError exception with https://gerrit.wikimedia.org/r/5424
Comment Actions
Actually, I'm not convinced on this anymore. It's used in a couple of places, not just AjaxDispatcher. Plus some extensions. It's basically harmless. Declined.