Page MenuHomePhabricator

first item in the history shows no information about its size
Closed, ResolvedPublic

Description

With MediaWiki 1.19 the history page was changed from showing the size to showing the diff and giving the size in the tooltip.

But now the first item in the history has no information about it size.

New pages in the RecentChanges getting the whole size as added, maybe the first item can get this also?

Thanks.


Version: 1.20.x
Severity: normal

Details

Reference
bz34198

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:11 AM
bzimport set Reference to bz34198.
bzimport added a subscriber: Unknown Object (MLST).

On Special:Contributions the new revisions has the same problem. Maybe also use the size of that page as added size?

Can you provide a link to this on en.wikimedia.beta.wmflabs.org? I'm not seeing this right now.

You can look at the history of a page[1]:

18:48, 8 February 2012‎ MarkAHershberger (Talk | contribs)‎ . . (+6)‎ . . (undo)
18:48, 8 February 2012‎ MarkAHershberger (Talk | contribs)‎ (←Created page with 'i̇̃')

The first item has a size (+6) the other does not.
Looking at Special:Contributions [2]:

18:48, 8 February 2012 (diff | hist) . . (+6)‎ . . Sandbox ‎ (top)
18:48, 8 February 2012 (diff | hist) N Sandbox ‎ (←Created page with 'i̇̃')

The first item has a size (+6) the other does not.
Looking at recentchanges [3]:

8 February 2012
(diff | hist) . . Sandbox‎; 18:48 . . (+6)‎ . . ‎MarkAHershberger (Talk | contribs)‎
(diff | hist) . . N Sandbox‎; 18:48 . . (+9)‎ . . ‎MarkAHershberger (Talk | contribs)‎ (←Created page with 'i̇̃')

Both items has a size

[1] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Sandbox&action=history
[2] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions/MarkAHershberger&offset=20120208184900&limit=2&target=MarkAHershberger
[3] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&from=20120208184700

Could you provide a patch for this? (Asking b/c you've done patches in
the past and may be able to track this down more quickly.)

Created attachment 9985
show always a size

I have create a patch, which change the two places in HistoryAction and SpecialContributions: If the prevRev or the parentLen not set, use a 0 for the old size.

The patch also improves the use of LinkBatch on that two pages.

Feel free to modify the patch.

Attached: