Page MenuHomePhabricator

If a message was in wmf-branch and isn't in trunk (and developers expect it to fall back to en), it cannot be updated by LU.
Closed, InvalidPublic

Description

From r103763, comment #c30191:

If a de message was in wmf-branch and isn't in trunk (and developers expect it to fall back to en), it cannot be updated by LU.

Some ways to fix:

  • Iterate over all keys in English where English text is not changed when updating (= building cache), then calculate (resolve fallback now) its message text in every language and store it in cache. When recaching the message, simply merging cached data into main data.
  • or, include English in l10ncache.

Version: unspecified
Severity: normal

Details

Reference
bz34272

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:15 AM
bzimport set Reference to bz34272.
bzimport added a subscriber: Unknown Object (MLST).

I don't understand when this situation would happen. WMF branches are not supposed to have code which is not in master first (expect security fixes).

Unless I have misunderstood, it is probably not worth it to try to solve this case.

(In reply to Niklas Laxström from comment #1)

I don't understand when this situation would happen. WMF branches are not
supposed to have code which is not in master first (expect security fixes).

Unless I have misunderstood, it is probably not worth it to try to solve
this case.

If I remember what I thought correctly... sometimes developers remove some messages from trunk in i18n files (as described in comment 0: the message is expected to be identical to the English one, but got translated somehow, by twn users for example, so the developer is cleaning it up), so at this time, trunk version shows English message, while wmfX version shows a localized message (which was but is no longer in trunk), and LU can't make wmfX show English message.

Anyway in our current deployment cycle, this very rare case lasts for at most one week. I don't think it's something important but it's still a bug which could occur in real world...

Jdforrester-WMF subscribed.

The LocalisationUpdate extensions has been archived. See T309694 for details.