Page MenuHomePhabricator

multi file selection with FF10 fails
Closed, ResolvedPublic

Description

Author: saibotrash

Description:
At least under Linux with FF10.

Select two files (with holding down shift key), try to upload, result:

testsmiley.jpg
This file might be corrupt, or have the wrong extension.

testsmiley.png
The file you submitted was empty.


Version: unspecified
Severity: normal

Details

Reference
bz34333

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:09 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz34333.
bzimport added a subscriber: Unknown Object (MLST).

Do you know if this happened with FF9 or Opera?

saibotrash wrote:

(In reply to comment #1)

Do you know if this happened with FF9 or Opera?

Don't have FF9 easily available.

Same error happening with Opera11.6 and English interface.
Same error happening with Opera11.6 and English interface and two fresh, never uploaded before files.
Same error happening with Opera11.6 and English interface and two fresh, never uploaded before files and selection via Ctrl key.

Could you please tell me if it works for you?

Created attachment 10018
FF 10: I used multiple selection two times: The first selected file uploads properly.

Does not work. Firefox 10.0.1 / windows

The first file selected works but all subsequent files don't.

Attached:

upwizBugFilesEmptyMultipleSelection.png (847×919 px, 38 KB)

Hehe the error is in

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UploadWizard/resources/mw.fileApi.js

$j.browser.mozilla && $j.browser.version >= '5.0'

returns false for firefox 10

Created attachment 10019
quick and dirty using parseint

attachment mw.fileApi.patch.js ignored as obsolete

Created attachment 10020
should be float not int

Attached:

r111604 -- was just about to ask about parseFloat ...

saibotrash wrote:

Reedy deployed the fix to Commons. Works for me with FF 10.0.2 on Linux now (selected two files via holding the Shift key down).