Page MenuHomePhabricator
Create Task
Maniphest T36428

PHP version of DiffHistoryBlob::patch() computes incorrect base text checksum
Closed, ResolvedPublic
Actions

Description

Some revisions stored with DiffHistoryBlob in Wikimedia external storage cannot be decoded if xdiff_string_bpatch() is not available and thus the PHP port is used. Revision::getText() returns false.

The debug log shows "incorrect base checksum". If the checksum check is disabled, the revision appears to be decoded successfully. Perhaps an incorrect implementation of the adler32 checksum is at fault.

Version: 1.19
Severity: normal

Details

Reference
bz34428

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:16 AM
• bzimport added a project: MediaWiki-Page-diffs.
• bzimport set Reference to bz34428.
• bzimport added a subscriber: Unknown Object (MLST).
tstarling created this task.Feb 16 2012, 12:34 AM
tstarling added a comment.Feb 16 2012, 11:56 AM

LibXDiff has an incorrect implementation of Adler-32. The byte order is wrong, and the state is initialised to 0 instead of 1.

If a string can be found for which the Adler-32 hash is zero, then that could be used to initialise mhash() or hash() to simulate LibXDiff's Adler-32.

tstarling added a comment.Feb 16 2012, 11:32 PM

Fixed in r111701.

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM
Aklapper removed a subscriber: • wikibugs-l-list.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL