carlb613 wrote:

I've looked at the PageCSS/PageCSS.php currently in trunk and it appears that the only thing which needs to change for it to work correctly is for the parser tag hook to return a value - a one-line change to return the empty string when done.

Nothing else which was changed between PageCSS and NewPageCSS actually makes a difference - whatever restrictions might have been encountered for Unicode in the description strings were specific to one previous MediaWiki version and have been resolved, rendering [[mw:extension:NewPageCSS]] unnecessary.

At this point, this is a bug fix for the PageCSS/PageCSS.php currently in trunk.

public static function parse( $content, array $args, Parser $parser ) {

		$css = htmlspecialchars( trim( Sanitizer::checkCss( $content ) ) );
		$parser->mOutput->addHeadItem( <<<EOT

<style type="text/css">
/*<![CDATA[*/
{$css}
/*]]>*/
</style>
EOT

		);
		return htmlspecialchars("");

}

I've changed the status of this item to be a one-line bug fix... not an enhancement.

carlb613 wrote:

The diff for PageCSS.php is (trivially):

40a41

		return htmlspecialchars("");

So why open a bug if you can change the code on-wiki? ;) I've fixed a reundancy in the new version cause htmlspecialchars("") === ''.

carlb613 wrote:

The original [[mw:extension:PageCSS]] has its code in version control, not on-wiki. The on-wiki code is a pointless fork of this code to [[mw:extension:NewPageCSS]]. We shouldn't have to fork code like this just for one trivial bugfix. As such, I've re-opened this to request the one-line fix in SVN that was needed two months ago (or needed since MW 1.18 came out last year).

http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/PageCSS/PageCSS.php still returns nothing from the final routine public static function CssHook::parse() and needs to return the empty string. This needs to be fixed in SVN (and git if this code turns up there, which so far it has not).

As for htmlspecialchars(""), that makes no difference either way - constant input will give constant output in this case - but we do need to return *something*, anything, even if it is an empty string or this will give UNIQ...QINU rubbish in the rendered output on MW 1.18+.