Page MenuHomePhabricator
Create Task
Maniphest T36466

All sections in Preferences visible
Closed, ResolvedPublic
Actions

Description

On Special:Preferences all sections except the current should be hidden via Javascript. This seems to be broken with 1.19.
I tested with Firefox 3.6.x on mw: and simple: and all sections are visible, as if no Javascript was present. It works in debug mode (i.e. when appending ?debug=true to the URL), and it works on beta.wmflabs.
The Javascript is loaded (I get the file https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.UserBuckets|ext.translate.selecttoinput|jquery.autoEllipsis%2CcheckboxShiftClick%2CclickTracking%2CcollapsibleTabs%2CdelayedBind%2ChighlightText%2Cjson%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Csuggestions%2CtabIndex|mediawiki.action.watch.ajax|mediawiki.api%2Chtmlform%2Cuser|mediawiki.api.watch|mediawiki.legacy.mwsuggest|mediawiki.page.ready|mediawiki.special.preferences&skin=vector&version=20120217T090945Z&*https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.UserBuckets|ext.translate.selecttoinput|jquery.autoEllipsis%2CcheckboxShiftClick%2CclickTracking%2CcollapsibleTabs%2CdelayedBind%2ChighlightText%2Cjson%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Csuggestions%2CtabIndex|mediawiki.action.watch.ajax|mediawiki.api%2Chtmlform%2Cuser|mediawiki.api.watch|mediawiki.legacy.mwsuggest|mediawiki.page.ready|mediawiki.special.preferences&skin=vector&version=20120217T090945Z&*, with the code that should hide the sections) but apparently isn't executed. There are no errors in the Javascript error log. Clearing the cache doesn't help.

Version: 1.19
Severity: normal
URL: https://www.mediawiki.org/wiki/Special:Preferences

Details

Reference
bz34466

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT33217 MediaWiki bugs to be fixed for 1.19wmf1 deployment (tracking)
 ResolvedNoneT36466 All sections in Preferences visible

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 12:08 AM
• bzimport added projects: Browser-Support-Firefox, MW-1.19.0-release, MediaWiki-Core-Preferences, JavaScript.
• bzimport set Reference to bz34466.
• bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.Feb 17 2012, 9:29 AM
Reedy added a comment.Feb 17 2012, 2:42 PM

Seeems fine on Chrome 19 and FF 10

You do see a flash of it incorrectly formatted before the JS etc is loaded in..

You've also pasted the urls without any (enough?) whitespace between them. So it looks like one REALLY long url ;)

• Cmcmahon added a comment.Feb 17 2012, 10:41 PM

I checked FF 9 and IE7 and Special:Preferences looked fine in both.

I did notice that the tabs other than "User profile" take a moment to load, but otherwise was fine.

kaldari added a comment.Feb 17 2012, 11:00 PM

I confirmed the bug in Firefox 3.6.16. Works with debug=true and in newer versions of Firefox.

kaldari added a comment.Feb 17 2012, 11:04 PM

Seems to be a race condition. If I do a hard reload with debug=true it renders correctly. But if I do a soft reload with debug=true it renders incorrectly.

kaldari added a comment.Feb 17 2012, 11:09 PM

The ResourceLoader module involved is mediawiki.special.preferences which is defined in resources/Resources.php. This module loads resources/mediawiki.special/mediawiki.special.preferences.js with no dependencies declared.

kaldari added a comment.Feb 18 2012, 12:12 AM

Hopefully fixed in r111802. Unfortunately, I can't reproduce the race condition in my local MediaWiki install (in Firefox 3), so we won't know for sure if this fixes it until it is deployed to simple.wikipedia.org.

kaldari added a comment.Feb 18 2012, 1:42 AM

Confirmed fixed on simple.wikipedia.org in Firefox 3.6.16.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL