Incorrect head scripts when useHeadElement=false
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	VitaliyFilippov
	Feb 22 2012, 9:02 PM

Description

The patch

There is a serious backwards compatibilty (with older skins) problem in MediaWiki 1.18.1: 'headscripts' template data is set incorrectly when useHeadElement=false. This a) causes mediawiki.page.startup to not load and b) duplicates scripts which added with $wgOut->addScript(...).
The fix is very simple - 1-line patch in the attachment.

Version: 1.18.x
Severity: major

Attached:

1.18.1-fix-headscripts.diff500 BDownload

Details

Reference: bz34600

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:18 AM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz34600.

• bzimport added a subscriber: Unknown Object (MLST).

VitaliyFilippov created this task.Feb 22 2012, 9:02 PM

(scripts are duplicated in <head> and bottom of the page)

Thanks for noticing, and thanks for the patch! Applied with a slight modification (removed the $this parameter to match the 1.19 function signature) in r112152.

Thanks for approving the patch. Do you plan to back-port it to 1.18.2?

I think you should back-port it, as well as bug 34687. These are serious bugs :).

Incorrect head scripts when useHeadElement=falseClosed, ResolvedPublicActions

Description

Details

Event Timeline

Incorrect head scripts when useHeadElement=false
Closed, ResolvedPublic
Actions