Page MenuHomePhabricator

Left alligned images should come alongside text
Closed, ResolvedPublic

Description

I was trying make the image come along side text for Tamil mobile page, was able to get it fixed with this change
http://ta.wikipedia.org/w/index.php?diff=1035058&oldid=1034263

I dont think this is ideal fix, since one cant add an extra div tag alongside wikitext just for mobilefrontend. So this might be an issue with mf. Correct me if am wrong.

[[Image:xyz.jpg|100px|left]] puts the image inside <div class="floatleft">, but the image doesnt come alongside the text and text goes down.

[[Image:xyz.jpg|100px|right]] puts the image inside <div class="floatright">, the image does come alongside the text.

So floatleft needed an extra style attribute for the image to come properly. I guess the style is missing in the class or something?

Feel free to undo/redo the below edit with a edit summary to reproduce the issue

http://ta.wikipedia.org/w/index.php?diff=1035058&oldid=1034263

I also noticed similar issue in http://ml.m.wikipedia.org.

I took the fix from de.m.wikipedia.org where they seem to add the styling as part of a template and the same goes for both mobile / desktop versions.


Version: unspecified
Severity: normal
URL: http://ta.m.wikipedia.org

Details

Reference
bz34686

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:13 AM
bzimport set Reference to bz34686.
bzimport added a subscriber: Unknown Object (MLST).

Patch to fix

Patched /extensions/MobileFrontend/stylesheets/common.css and it worked fine locally! Not a great deal, but first patch submitted :)

Attached:

sumanah wrote:

Patch awaits review; added keyword. Thanks, Srikanth.

I've applied the patch in r112622
Thanks so much for your contribution!