patch for changing from table layout to CSS layout
The login and registration forms are using tables for laying out the page. I propose the attached patch to change it to CSS. The patch also includes the usage of methods (i. e. Html::element()) for creating the form fields instead of embedded HTML. The patch also removes the default type attributes' value to make sure the CSS-selector for "input type=text" is working.
Version: 1.18.x
Severity: normal
Attached:
sumanah wrote:
Thanks for the patch, Kai Nissen! I've added keywords to indicate that this patch awaits review (see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes ) and given you Bugzilla privileges so you can add those keywords in the future, if you need to. Thanks again.
By the way, this bug has also been mentioned by the accessibility report that was carried out by the swiss foundation "access for all".
See paragraph 1.3.1.C1 and 1.3.1.D2 for details.
http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/
We shouldn't add that much CSS to the file loaded on every request. Also, HTML generation code is scary (and presently, too) - it would make a lot of sense to migrate this stuff to HTMLForm (there are tentative plans to make it optionally not use tables).
sumanah wrote:
Marking reviewed per comment #5 -- Kai, would you be interested in revising and responding with a Gerrit changeset? Thanks.
MediaWiki 1.22wmf2 introduces mw-ui- CSS styles for a new vertical form layout. It's currently opt-in for login (try at http://www.mediawiki.org/w/index.php?title=Special:UserLogin&useNew=1 ).
(In reply to comment #5)
it would make a lot of sense to migrate this stuff to HTMLForm
That remains to do (some initial work in gerrit 56058) so I'm leaving this bug open.