Page MenuHomePhabricator

[patch] StalePages extension: Failed opening $IP/extensions/StalePages/Stalepages.alias.php
Closed, ResolvedPublic

Description

Author: andrew.daugherity+wikibugs

Description:
fix capitalization of StalePages.alias.php in $wgExtensionMessagesFiles

Every so often, probably whenever it decides to update the LocalisationCache, I get this traceback in my apache error log:

[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP Warning: include(): Failed opening '$IP/extensions/StalePages/Stalepages.alias.php' for inclusion (include_path='$IP:$IP/includes:$IP/wiki/languages:.:/usr/share/php5:/usr/share/php5/PEAR') in $IP/includes/LocalisationCache.php on line 411, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP Stack trace:, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 1. {main}() $IP/index.php:0, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 2. MediaWiki->performRequestForTitle() $IP/index.php:114, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 3. MediaWiki->preliminaryChecks() $IP/includes/Wiki.php:58, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 4. Title->userCanRead() $IP/includes/Wiki.php:155, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 5. User->isAllowed() $IP/includes/Title.php:1790, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 6. User->getRights() $IP/includes/User.php:2248, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 7. User->getEffectiveGroups() $IP/includes/User.php:2097, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 8. User->getGroups() $IP/includes/User.php:2125, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 9. User->load() $IP/includes/User.php:2111, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 10. User->loadFromSession() $IP/includes/User.php:226, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 11. User->getToken() $IP/includes/User.php:924, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 12. User->load() $IP/includes/User.php:1848, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 13. User->loadFromId() $IP/includes/User.php:223, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 14. User->saveToCache() $IP/includes/User.php:262, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 15. User->loadOptions() $IP/includes/User.php:279, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 16. User::getDefaultOptions() $IP/includes/User.php:3656, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 17. Language->getDefaultUserOptionOverrides() $IP/includes/User.php:1075, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 18. LocalisationCache->getItem() $IP/languages/Language.php:471, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 19. LocalisationCache->loadItem() $IP/includes/LocalisationCache.php:211, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 20. LocalisationCache->initLanguage() $IP/includes/LocalisationCache.php:268, referer: $wgServer/wiki/index.php/Special:SpecialPages
[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 21. LocalisationCache->recache() $IP/includes/LocalisationCache.php:358, referer: $wgServer/wiki/index.php/Special:SpecialPages

[Fri Feb 24 16:53:16 2012] [error] [client 165.91.114.185] PHP 22. LocalisationCache->readPHPFile() $IP/includes/LocalisationCache.php:572, referer: $wgServer/wiki/index.php/Special:SpecialPages

(The path and server are logged; I have replaced them with $IP and $wgServer myself.)

It's looking for Stalepages.alias.php but the filename is actually StalePages.alias.php (note capitalization). Changing the $wgExtensionMessagesFiles reference in StalePages.php fixes the problem. One-line patch is attached.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz34757

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:18 AM
bzimport set Reference to bz34757.
bzimport added a subscriber: Unknown Object (MLST).

sumanah wrote:

Thanks for the patch, Andrew!

sumanah wrote:

CC'ing iAlex since he's one of the last people to touch this extension. Alex, can I ask for a patch review? Thanks.